Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support/wagtail 42 upgrade #936

Merged
merged 9 commits into from
Sep 18, 2023
Merged

Support/wagtail 42 upgrade #936

merged 9 commits into from
Sep 18, 2023

Conversation

nickmoreton
Copy link
Contributor

@nickmoreton nickmoreton commented Apr 26, 2023

This upgrade wagtail to v4.2

Support ticket: 1166257309

Some of the changes here are not specifically for this upgrade and look like they are items form either version upgrades that were missed.

  • Imports and use_json_field + some migrations
  • wagtail_redirect_importer (removed as it's now part of wagtail since 2.10)

Additionally:

  • Check Student page inline javascript still works as expected. 8bcefd4

@nickmoreton nickmoreton force-pushed the support/wagtail-42-upgrade branch from 14827a0 to 64cb594 Compare May 2, 2023 15:29
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Merging #936 (b20f800) into master (d73ea18) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #936      +/-   ##
==========================================
- Coverage   52.99%   52.97%   -0.02%     
==========================================
  Files         161      161              
  Lines        7688     7686       -2     
  Branches      164      164              
==========================================
- Hits         4074     4072       -2     
  Misses       3497     3497              
  Partials      117      117              
Files Changed Coverage Δ
rca/programmes/models.py 73.15% <ø> (ø)
rca/projects/models.py 47.86% <ø> (-0.25%) ⬇️
rca/settings/base.py 62.96% <ø> (ø)
rca/shortcourses/models.py 86.77% <100.00%> (-0.11%) ⬇️

@alxbridge alxbridge self-requested a review May 12, 2023 13:45
Copy link
Contributor

@alxbridge alxbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickmoreton These changes all look good, and are complete as far as I can see. I've also done some testing of the site functionality, though I've not checked all the critical paths from the upgrading doc.

praise Thanks also for catching and addressing the changes which were still needed from previous upgrades.

@nickmoreton nickmoreton added the on-dev Flag to state if this code is on the dev site label Jun 2, 2023
@katdom13 katdom13 mentioned this pull request Jul 11, 2023
@alxbridge alxbridge force-pushed the support/wagtail-42-upgrade branch from 2a9c895 to b68ca19 Compare September 18, 2023 13:36
@alxbridge alxbridge merged commit 1ec2ef5 into master Sep 18, 2023
@alxbridge alxbridge deleted the support/wagtail-42-upgrade branch September 18, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-dev Flag to state if this code is on the dev site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants