Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade poetry to 1.5.0 #937

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Upgrade poetry to 1.5.0 #937

merged 2 commits into from
Aug 16, 2023

Conversation

nickmoreton
Copy link
Contributor

This upgrades poetry to v 1.5.0

Support ticket: 1198296347

PR: #936 is currently blocked by this.

@nickmoreton nickmoreton force-pushed the support/upgrade-poetry branch 4 times, most recently from 233abac to 98977bb Compare May 22, 2023 14:30
@nickmoreton nickmoreton force-pushed the support/upgrade-poetry branch from 98977bb to 30cf0bf Compare May 22, 2023 15:00
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2023

Codecov Report

Merging #937 (5acc73f) into master (94ff760) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #937   +/-   ##
=======================================
  Coverage   52.80%   52.80%           
=======================================
  Files         160      160           
  Lines        7587     7587           
  Branches      164      164           
=======================================
  Hits         4006     4006           
  Misses       3464     3464           
  Partials      117      117           

@alxbridge
Copy link
Contributor

I've just pushed a commit to fix the CircleCI config, so that Poetry can be upgraded past v1.2: the issue is that CircleCI doesn't provide full terminal emulation, and newer versions of Poetry require terminal features that go beyond what it does provide.

The good news is that these features can be disabled by adding the --no-ansi flag to any poetry commands.

See python-poetry/poetry#7184 for full details

@nickmoreton nickmoreton added the on-dev Flag to state if this code is on the dev site label Jun 2, 2023
@nickmoreton nickmoreton merged commit dbb7935 into master Aug 16, 2023
@nickmoreton nickmoreton deleted the support/upgrade-poetry branch August 16, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-dev Flag to state if this code is on the dev site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants