Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for flatten #137

Closed
ssi02014 opened this issue Jul 8, 2024 · 0 comments · Fixed by #147
Closed

Support for flatten #137

ssi02014 opened this issue Jul 8, 2024 · 0 comments · Fixed by #147

Comments

@ssi02014
Copy link
Contributor

ssi02014 commented Jul 8, 2024 •
edited
Loading

Work with flatten as discussed in the issue above.

Implement the same function as lodash's flattenDepth under the name flatten(arr, depth).

It should allow the same type inference as Array.prototype.flat.

flatten should perform better than Array.prototype.flat and lodash's flattenDepth.
@ssi02014 ssi02014 changed the title Support for flatten Support for flatten Jul 8, 2024
ssi02014 added a commit to ssi02014/es-toolkit that referenced this issue Jul 9, 2024
@ssi02014
feat(flatten): add faltten (toss#137)
bed9e30
ssi02014 added a commit to ssi02014/es-toolkit that referenced this issue Jul 9, 2024
@ssi02014
feat(flatten): add faltten (toss#137)
baa5376
ssi02014 added a commit to ssi02014/es-toolkit that referenced this issue Jul 9, 2024
@ssi02014
feat(flatten): add faltten (toss#137)
96dc002
@ssi02014 ssi02014 mentioned this issue Jul 9, 2024
Merged
raon0211 added a commit that referenced this issue Jul 10, 2024
@ssi02014 @raon0211
feat(flatten): add flatten (#147)
7c82462 
* feat(flatten): add faltten (#137)

* fix: fix lint

* fix: fix test code description

* test(flatten): add test case

* Update docs/ko/reference/array/flatten.md

* Update docs/ko/reference/array/flatten.md

* Update docs/ko/reference/array/flatten.md

* Update docs/reference/array/flatten.md

---------

Co-authored-by: Sojin Park <raon0211@gmail.com>
@raon0211 raon0211 mentioned this issue Jul 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(flatten): add flatten ssi02014/es-toolkit
1 participant
@ssi02014