Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flatten): add flatten #147

Merged
merged 8 commits into from
Jul 10, 2024
Merged

feat(flatten): add flatten #147

merged 8 commits into from
Jul 10, 2024

Conversation

ssi02014
Copy link
Contributor

@ssi02014 ssi02014 commented Jul 9, 2024

close: #137

Implement the same function as lodash's flattenDepth under the name flatten(arr, depth).

It works the same as Array.prototype.flat provided by default in JavaScript and returns the same type. However, its performance is superior.

benchmark

스크린샷 2024-07-10 오전 1 23 39

@ssi02014 ssi02014 requested a review from raon0211 as a code owner July 9, 2024 16:36
Copy link

vercel bot commented Jul 9, 2024

@ssi02014 is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3c8d105) to head (ecba55b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #147   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           68        69    +1     
  Lines          384       395   +11     
  Branches        49        52    +3     
=========================================
+ Hits           384       395   +11     

@ssi02014 ssi02014 changed the title feat(flatten): add faltten (#137) feat(flatten): add flatten (#137) Jul 9, 2024
@raon0211 raon0211 changed the title feat(flatten): add flatten (#137) feat(flatten): add flatten Jul 10, 2024
Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your great contribution!

@raon0211 raon0211 merged commit 7c82462 into toss:main Jul 10, 2024
5 of 7 checks passed
@ssi02014 ssi02014 deleted the feat/flatten branch July 10, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for flatten
3 participants