Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Bubble chart for contributors page #1012

Closed
manudeli opened this issue Jun 30, 2024 · 1 comment · Fixed by #1043
Closed

[Feature] Bubble chart for contributors page #1012

manudeli opened this issue Jun 30, 2024 · 1 comment · Fixed by #1043

Comments

@manudeli
Copy link
Member

          This is a very minor comment, so please take it lightly.

I think the current purpose of the maintainer or contributor page is to encourage contributions, and if it's meant to be more encouraging, what if the page looked different based on the size of the contribution?

The simplest UI direction I could think of was something like a bubble chart

example image
image

It's good enough as it is! Thank you!

Originally posted by @minsoo-web in #1011 (comment)

manudeli added a commit that referenced this issue Jul 7, 2024
# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I found the bubble chart idea for the contributors page from here
#1012 really interesting, so I
decided to give it a try and here's how it looks. Clicking on the bubble
will redirect to each contributor's github page.

![Captura de pantalla 2024-07-07 a las 9 59 00 p
 m](https://github.com/toss/suspensive/assets/82362278/20646b0e-1ea2-45c5-b75a-c22275822b50)



## PR Checklist

- [✅] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------

Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
@manudeli manudeli linked a pull request Jul 7, 2024 that will close this issue
@manudeli manudeli closed this as completed Jul 7, 2024
@manudeli
Copy link
Member Author

manudeli commented Jul 7, 2024

@minsoo-web Thanks for your idea!
@saul-atomrigs Thanks for your work!

In my opinion, This is so much better than before!

chrome-capture-2024-7-8

manudeli added a commit that referenced this issue Aug 3, 2024
# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I found the bubble chart idea for the contributors page from here
#1012 really interesting, so I
decided to give it a try and here's how it looks. Clicking on the bubble
will redirect to each contributor's github page.

![Captura de pantalla 2024-07-07 a las 9 59 00 p
 m](https://github.com/toss/suspensive/assets/82362278/20646b0e-1ea2-45c5-b75a-c22275822b50)



## PR Checklist

- [✅] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------

Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
manudeli pushed a commit that referenced this issue Aug 3, 2024
# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I found the bubble chart idea for the contributors page from here
#1012 really interesting, so I
decided to give it a try and here's how it looks. Clicking on the bubble
will redirect to each contributor's github page.

![Captura de pantalla 2024-07-07 a las 9 59 00 p
 m](https://github.com/toss/suspensive/assets/82362278/20646b0e-1ea2-45c5-b75a-c22275822b50)



## PR Checklist

- [✅] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------
manudeli added a commit that referenced this issue Aug 3, 2024
# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I found the bubble chart idea for the contributors page from here
#1012 really interesting, so I
decided to give it a try and here's how it looks. Clicking on the bubble
will redirect to each contributor's github page.

![Captura de pantalla 2024-07-07 a las 9 59 00 p
 m](https://github.com/toss/suspensive/assets/82362278/20646b0e-1ea2-45c5-b75a-c22275822b50)



## PR Checklist

- [✅] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------

Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
manudeli added a commit that referenced this issue Aug 3, 2024
# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I found the bubble chart idea for the contributors page from here
#1012 really interesting, so I
decided to give it a try and here's how it looks. Clicking on the bubble
will redirect to each contributor's github page.

![Captura de pantalla 2024-07-07 a las 9 59 00 p
 m](https://github.com/toss/suspensive/assets/82362278/20646b0e-1ea2-45c5-b75a-c22275822b50)



## PR Checklist

- [✅] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------

Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants