Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(suspensive.org): add bubble chart for contributors page #1043

Merged
merged 2 commits into from
Jul 7, 2024
Merged

feat(suspensive.org): add bubble chart for contributors page #1043

merged 2 commits into from
Jul 7, 2024

Conversation

saul-atomrigs
Copy link
Contributor

Overview

I found the bubble chart idea for the contributors page from here #1012 really interesting, so I decided to give it a try and here's how it looks. Clicking on the bubble will redirect to each contributor's github page.

Captura de pantalla 2024-07-07 a las 9 59 00 p  m

PR Checklist

  • [✅] I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

@saul-atomrigs saul-atomrigs requested a review from manudeli as a code owner July 7, 2024 13:21
Copy link

changeset-bot bot commented Jul 7, 2024

⚠️ No Changeset found

Latest commit: edafc8d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2024 4:59pm
v1.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2024 4:59pm
visualization.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2024 4:59pm

Copy link

vercel bot commented Jul 7, 2024

@saul-atomrigs is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.34%. Comparing base (421fa2e) to head (edafc8d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1043   +/-   ##
=======================================
  Coverage   85.34%   85.34%           
=======================================
  Files          45       45           
  Lines         539      539           
  Branches      118      117    -1     
=======================================
  Hits          460      460           
  Misses         74       74           
  Partials        5        5           
Components Coverage Δ
@suspensive/react 97.03% <ø> (ø)
@suspensive/react-query 75.28% <ø> (ø)
@suspensive/react-query-4 0.00% <ø> (ø)
@suspensive/react-query-5 0.00% <ø> (ø)
@suspensive/react-await 100.00% <ø> (ø)
@suspensive/react-image 80.39% <ø> (ø)

Copy link

codspeed-hq bot commented Jul 7, 2024

CodSpeed Performance Report

Merging #1043 will create unknown performance changes

Comparing saul-atomrigs:contributors-bubble-chart (edafc8d) with main (421fa2e)

Summary

⚠️ No benchmarks were detected in both the base of the PR and the PR.

@manudeli
Copy link
Member

manudeli commented Jul 7, 2024

chrome-capture-2024-7-8

Thanks! @saul-atomrigs I improved your wonderful work too! 👍👍👍

  1. I modified the contributor's profile image to be better exposed even on small screens by removing the unnecessary gray margin around the image.
  2. I changed it to a responsive design so that it is displayed well on all devices.

@manudeli manudeli merged commit e9c3234 into toss:main Jul 7, 2024
14 checks passed
@manudeli manudeli linked an issue Jul 7, 2024 that may be closed by this pull request
@minsoo-web
Copy link
Member

wow... thank you @saul-atomrigs 🚀🚀🚀

@saul-atomrigs
Copy link
Contributor Author

@manudeli Thanks for the improvements, it loooks way better!! 😆😆😆
@minsoo-web Thank you for your great idea!!!

manudeli added a commit that referenced this pull request Aug 3, 2024
# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I found the bubble chart idea for the contributors page from here
#1012 really interesting, so I
decided to give it a try and here's how it looks. Clicking on the bubble
will redirect to each contributor's github page.

![Captura de pantalla 2024-07-07 a las 9 59 00 p
 m](https://github.com/toss/suspensive/assets/82362278/20646b0e-1ea2-45c5-b75a-c22275822b50)



## PR Checklist

- [✅] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------

Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
manudeli pushed a commit that referenced this pull request Aug 3, 2024
# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I found the bubble chart idea for the contributors page from here
#1012 really interesting, so I
decided to give it a try and here's how it looks. Clicking on the bubble
will redirect to each contributor's github page.

![Captura de pantalla 2024-07-07 a las 9 59 00 p
 m](https://github.com/toss/suspensive/assets/82362278/20646b0e-1ea2-45c5-b75a-c22275822b50)



## PR Checklist

- [✅] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------
manudeli added a commit that referenced this pull request Aug 3, 2024
# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I found the bubble chart idea for the contributors page from here
#1012 really interesting, so I
decided to give it a try and here's how it looks. Clicking on the bubble
will redirect to each contributor's github page.

![Captura de pantalla 2024-07-07 a las 9 59 00 p
 m](https://github.com/toss/suspensive/assets/82362278/20646b0e-1ea2-45c5-b75a-c22275822b50)



## PR Checklist

- [✅] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------

Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
manudeli added a commit that referenced this pull request Aug 3, 2024
# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I found the bubble chart idea for the contributors page from here
#1012 really interesting, so I
decided to give it a try and here's how it looks. Clicking on the bubble
will redirect to each contributor's github page.

![Captura de pantalla 2024-07-07 a las 9 59 00 p
 m](https://github.com/toss/suspensive/assets/82362278/20646b0e-1ea2-45c5-b75a-c22275822b50)



## PR Checklist

- [✅] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------

Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Bubble chart for contributors page
4 participants