Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: add SuspensePromise, useSuspensePromise, promiseOptions, PromiseCache, PromiseCacheProvider, usePromiseCache #1069

Closed
SEOKKAMONI opened this issue Jul 10, 2024 · 3 comments · Fixed by #1074
Assignees

Comments

@SEOKKAMONI
Copy link
Contributor

SEOKKAMONI commented Jul 10, 2024

Package Scope

@suspensive/promise

Description

add SuspensePromise, promiseOptions, PromiseCacheProvider, usePromiseCache

Possible Solution

No response

etc.

No response

@manudeli
Copy link
Member

@SEOKKAMONI In my opinion, we should try to focus @suspensive/promise. Make it in @suspensive/promise please
or Could you share plan you want?

@SEOKKAMONI
Copy link
Contributor Author

SEOKKAMONI commented Jul 11, 2024

@SEOKKAMONI In my opinion, we should try to focus @suspensive/promise. Make it in @suspensive/promise please or Could you share plan you want?

I agree your opinion. Then, I will change the issue to add SuspensePromise, promiseOptions, and PromiseCacheProvider, usePromiseCache

@SEOKKAMONI SEOKKAMONI changed the title [Feature]: add AwaitClientProvider [Feature]: add SuspensePromise, promiseOptions, PromiseCacheProvider, usePromiseCache Jul 11, 2024
@manudeli
Copy link
Member

@SEOKKAMONI In my opinion, we should try to focus @suspensive/promise. Make it in @suspensive/promise please or Could you share plan you want?

I agree your opinion. Then, I will change the issue to add SuspensePromise, promiseOptions, and PromiseCacheProvider ...

Cool Let's move to make @suspensive/promise from version 0 to version 1

@SEOKKAMONI SEOKKAMONI changed the title [Feature]: add SuspensePromise, promiseOptions, PromiseCacheProvider, usePromiseCache [Feature]: @suspensive/promiose Jul 11, 2024
@SEOKKAMONI SEOKKAMONI changed the title [Feature]: @suspensive/promiose [Feature]: @suspensive/promise Jul 11, 2024
@SEOKKAMONI SEOKKAMONI changed the title [Feature]: @suspensive/promise [Feature]: add SuspensePromise, useSuspensePromise, promiseOptions, PromiseCache, PromiseCacheProvider, usePromiseCache Jul 13, 2024
manudeli added a commit that referenced this issue Aug 3, 2024
…s, PromiseCache, PromiseCacheProvider, usePromiseCache (#1074)

related with #1076
close #1069

# Overview

- add SuspensePromise, useSuspensePromise, promiseOptions, PromiseCache,
PromiseCacheProvider, usePromiseCache
<!--
    A clear and concise description of what this pr is about.
 -->

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------

Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
manudeli pushed a commit that referenced this issue Aug 3, 2024
…s, PromiseCache, PromiseCacheProvider, usePromiseCache (#1074)

related with #1076
close #1069

# Overview

- add SuspensePromise, useSuspensePromise, promiseOptions, PromiseCache,
PromiseCacheProvider, usePromiseCache
<!--
    A clear and concise description of what this pr is about.
 -->

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------
manudeli added a commit that referenced this issue Aug 3, 2024
…s, PromiseCache, PromiseCacheProvider, usePromiseCache (#1074)

related with #1076
close #1069

# Overview

- add SuspensePromise, useSuspensePromise, promiseOptions, PromiseCache,
PromiseCacheProvider, usePromiseCache
<!--
    A clear and concise description of what this pr is about.
 -->

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------

Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
manudeli added a commit that referenced this issue Aug 3, 2024
…s, PromiseCache, PromiseCacheProvider, usePromiseCache (#1074)

related with #1076
close #1069

# Overview

- add SuspensePromise, useSuspensePromise, promiseOptions, PromiseCache,
PromiseCacheProvider, usePromiseCache
<!--
    A clear and concise description of what this pr is about.
 -->

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------

Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants