feat(promise): add SuspensePromise, useSuspensePromise, promiseOptions, PromiseCache, PromiseCacheProvider, usePromiseCache #1074

SEOKKAMONI · 2024-07-13T13:09:12Z

related with #1076
close #1069

Overview

add SuspensePromise, useSuspensePromise, promiseOptions, PromiseCache, PromiseCacheProvider, usePromiseCache

PR Checklist

I did below actions if need

I read the Contributing Guide
I added documents and tests.

…s, PromiseCache

changeset-bot · 2024-07-13T13:09:16Z

🦋 Changeset detected

Latest commit: 39babc9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@suspensive/promise	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2024-07-13T13:09:17Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
suspensive.org	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 13, 2024 2:56pm
v1.suspensive.org	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 13, 2024 2:56pm
visualization.suspensive.org	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 13, 2024 2:56pm

vercel · 2024-07-13T13:09:19Z

@SEOKKAMONI is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

SEOKKAMONI

I thought it would be better to review document additions in separate issues, so I did not handle them all at once. I plan to add the documents in a future issue.

SEOKKAMONI · 2024-07-13T13:12:20Z

packages/promise/src/PromiseCacheProvider.tsx

+import { type PropsWithChildren } from 'react'
+import { PromiseCacheContext } from './contexts'
+import type { PromiseCache } from './PromiseCache'
+
+type PromiseCacheProviderProps = PropsWithChildren<{ cache: PromiseCache }>
+
+/**
+ * @experimental This is experimental feature.
+ */
+export const PromiseCacheProvider = ({ cache, children }: PromiseCacheProviderProps) => (
+  <PromiseCacheContext.Provider value={cache}>{children}</PromiseCacheContext.Provider>
+)


Here is the implementation reflecting the review from #1066 (comment)

codspeed-hq · 2024-07-13T13:20:57Z

CodSpeed Performance Report

Merging #1074 will create unknown performance changes

_{Comparing SEOKKAMONI:feat/promise (39babc9) with main (7eb9e9b)}

Summary

⚠️ No benchmarks were detected in both the base of the PR and the PR.

codecov-commenter · 2024-07-13T13:21:45Z

Codecov Report

Attention: Patch coverage is 94.17476% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.77%. Comparing base (7eb9e9b) to head (39babc9).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1074      +/-   ##
==========================================
+ Coverage   84.23%   85.77%   +1.54%     
==========================================
  Files          54       63       +9     
  Lines         552      654     +102     
  Branches      117      141      +24     
==========================================
+ Hits          465      561      +96     
- Misses         82       87       +5     
- Partials        5        6       +1

Components	Coverage Δ
@suspensive/react	`97.05% <ø> (ø)`
@suspensive/react-query	`75.28% <ø> (ø)`
@suspensive/react-query-4	`0.00% <ø> (ø)`
@suspensive/react-query-5	`0.00% <ø> (ø)`
@suspensive/jotai	`0.00% <ø> (ø)`
@suspensive/promise	`94.17% <94.17%> (-5.83%)`	⬇️
@suspensive/react-await	`100.00% <ø> (ø)`
@suspensive/react-image	`80.39% <ø> (ø)`

Co-authored-by: Jonghyeon Ko <61593290+manudeli@users.noreply.github.com>

packages/promise/src/index.ts

manudeli · 2024-07-13T14:51:17Z

@SEOKKAMONI Could you resolve eslint error

@SEOKKAMONI

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @suspensive/promise@0.1.0 ### Minor Changes - [#1074](#1074) [`32bd5ab`](32bd5ab) Thanks [@SEOKKAMONI](https://github.com/SEOKKAMONI)! - feat(promise): add SuspensePromise, useSuspensePromise, promiseOptions, PromiseCache, PromiseCacheProvider, usePromiseCache Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…s, PromiseCache, PromiseCacheProvider, usePromiseCache (#1074) related with #1076 close #1069 # Overview - add SuspensePromise, useSuspensePromise, promiseOptions, PromiseCache, PromiseCacheProvider, usePromiseCache  ## PR Checklist - [x] I did below actions if need 1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md) 2. I added documents and tests. --------- Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>

@SEOKKAMONI

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @suspensive/promise@0.1.0 ### Minor Changes - [#1074](#1074) [`32bd5ab`](32bd5ab) Thanks [@SEOKKAMONI](https://github.com/SEOKKAMONI)! - feat(promise): add SuspensePromise, useSuspensePromise, promiseOptions, PromiseCache, PromiseCacheProvider, usePromiseCache Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…s, PromiseCache, PromiseCacheProvider, usePromiseCache (#1074) related with #1076 close #1069 # Overview - add SuspensePromise, useSuspensePromise, promiseOptions, PromiseCache, PromiseCacheProvider, usePromiseCache  ## PR Checklist - [x] I did below actions if need 1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md) 2. I added documents and tests. ---------

@SEOKKAMONI

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @suspensive/promise@0.1.0 ### Minor Changes - [#1074](#1074) [`32bd5ab`](32bd5ab) Thanks [@SEOKKAMONI](https://github.com/SEOKKAMONI)! - feat(promise): add SuspensePromise, useSuspensePromise, promiseOptions, PromiseCache, PromiseCacheProvider, usePromiseCache

…s, PromiseCache, PromiseCacheProvider, usePromiseCache (#1074) related with #1076 close #1069 # Overview - add SuspensePromise, useSuspensePromise, promiseOptions, PromiseCache, PromiseCacheProvider, usePromiseCache  ## PR Checklist - [x] I did below actions if need 1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md) 2. I added documents and tests. --------- Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>

@SEOKKAMONI

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @suspensive/promise@0.1.0 ### Minor Changes - [#1074](#1074) [`32bd5ab`](32bd5ab) Thanks [@SEOKKAMONI](https://github.com/SEOKKAMONI)! - feat(promise): add SuspensePromise, useSuspensePromise, promiseOptions, PromiseCache, PromiseCacheProvider, usePromiseCache

…s, PromiseCache, PromiseCacheProvider, usePromiseCache (#1074) related with #1076 close #1069 # Overview - add SuspensePromise, useSuspensePromise, promiseOptions, PromiseCache, PromiseCacheProvider, usePromiseCache  ## PR Checklist - [x] I did below actions if need 1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md) 2. I added documents and tests. --------- Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>

@SEOKKAMONI

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @suspensive/promise@0.1.0 ### Minor Changes - [#1074](#1074) [`32bd5ab`](32bd5ab) Thanks [@SEOKKAMONI](https://github.com/SEOKKAMONI)! - feat(promise): add SuspensePromise, useSuspensePromise, promiseOptions, PromiseCache, PromiseCacheProvider, usePromiseCache

SEOKKAMONI added 2 commits July 11, 2024 17:34

feat(promise): add SuspensePromise, useSuspensePromise, promiseOption…

3240ac2

…s, PromiseCache

feat(promise): add PromiseCacheProvider

20a2a05

SEOKKAMONI requested a review from manudeli as a code owner July 13, 2024 13:09

SEOKKAMONI marked this pull request as draft July 13, 2024 13:09

github-actions bot added the @suspensive/promise label Jul 13, 2024

vercel bot deployed to Preview – v1.suspensive.org July 13, 2024 13:09 View deployment

vercel bot deployed to Preview – visualization.suspensive.org July 13, 2024 13:10 View deployment

SEOKKAMONI commented Jul 13, 2024

View reviewed changes

vercel bot deployed to Preview – visualization.suspensive.org July 13, 2024 13:19 View deployment

vercel bot deployed to Preview – v1.suspensive.org July 13, 2024 13:20 View deployment

fix(promise): fix key -> promiseKey, fn -> promiseFn

6d30882

vercel bot deployed to Preview – visualization.suspensive.org July 13, 2024 13:24 View deployment

vercel bot deployed to Preview – v1.suspensive.org July 13, 2024 13:25 View deployment

SEOKKAMONI marked this pull request as ready for review July 13, 2024 13:27

SEOKKAMONI changed the title ~~(WIP) feat(promise): add @suspensive/promise package~~ feat(promise): add @suspensive/promise package Jul 13, 2024

SEOKKAMONI marked this pull request as draft July 13, 2024 13:28

vercel bot deployed to Preview – v1.suspensive.org July 13, 2024 13:31 View deployment

vercel bot deployed to Preview – visualization.suspensive.org July 13, 2024 13:31 View deployment

SEOKKAMONI marked this pull request as ready for review July 13, 2024 13:32

chore(promise): add changeset

405a7b1

Co-authored-by: Jonghyeon Ko <61593290+manudeli@users.noreply.github.com>

vercel bot deployed to Preview – v1.suspensive.org July 13, 2024 14:39 View deployment

vercel bot deployed to Preview – visualization.suspensive.org July 13, 2024 14:40 View deployment

vercel bot deployed to Preview – suspensive.org July 13, 2024 14:46 View deployment

Delete .changeset/twelve-buttons-do.md

ea3107e

vercel bot deployed to Preview – visualization.suspensive.org July 13, 2024 14:47 View deployment

vercel bot deployed to Preview – v1.suspensive.org July 13, 2024 14:48 View deployment

manudeli approved these changes Jul 13, 2024

View reviewed changes

packages/promise/src/index.ts Outdated Show resolved Hide resolved

Update packages/promise/src/index.ts

8592f10

manudeli assigned SEOKKAMONI Jul 13, 2024

vercel bot deployed to Preview – visualization.suspensive.org July 13, 2024 14:49 View deployment

vercel bot deployed to Preview – v1.suspensive.org July 13, 2024 14:49 View deployment

manudeli changed the title ~~feat(promise): add @suspensive/promise package~~ feat(promise): add SuspensePromise, useSuspensePromise, promiseOptions, PromiseCache, PromiseCacheProvider, usePromiseCache Jul 13, 2024

Create blue-apricots-love.md

4896ea8

vercel bot deployed to Preview – visualization.suspensive.org July 13, 2024 14:52 View deployment

vercel bot deployed to Preview – v1.suspensive.org July 13, 2024 14:53 View deployment

vercel bot deployed to Preview – suspensive.org July 13, 2024 14:54 View deployment

fix(promise): fix eslint error

39babc9

vercel bot deployed to Preview – v1.suspensive.org July 13, 2024 14:55 View deployment

vercel bot deployed to Preview – visualization.suspensive.org July 13, 2024 14:56 View deployment

vercel bot deployed to Preview – suspensive.org July 13, 2024 14:56 View deployment

manudeli merged commit 32bd5ab into toss:main Jul 13, 2024
14 checks passed

github-actions bot mentioned this pull request Jul 13, 2024

chore: version packages #1078

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(promise): add SuspensePromise, useSuspensePromise, promiseOptions, PromiseCache, PromiseCacheProvider, usePromiseCache #1074

feat(promise): add SuspensePromise, useSuspensePromise, promiseOptions, PromiseCache, PromiseCacheProvider, usePromiseCache #1074

SEOKKAMONI commented Jul 13, 2024 •

edited by manudeli

Loading

changeset-bot bot commented Jul 13, 2024 •

edited

Loading

vercel bot commented Jul 13, 2024 •

edited

Loading

vercel bot commented Jul 13, 2024

SEOKKAMONI left a comment

SEOKKAMONI Jul 13, 2024

codspeed-hq bot commented Jul 13, 2024 •

edited

Loading

codecov-commenter commented Jul 13, 2024 •

edited

Loading

manudeli commented Jul 13, 2024

feat(promise): add SuspensePromise, useSuspensePromise, promiseOptions, PromiseCache, PromiseCacheProvider, usePromiseCache #1074

feat(promise): add SuspensePromise, useSuspensePromise, promiseOptions, PromiseCache, PromiseCacheProvider, usePromiseCache #1074

Conversation

SEOKKAMONI commented Jul 13, 2024 • edited by manudeli Loading

Overview

PR Checklist

changeset-bot bot commented Jul 13, 2024 • edited Loading

🦋 Changeset detected

vercel bot commented Jul 13, 2024 • edited Loading

vercel bot commented Jul 13, 2024

SEOKKAMONI left a comment

Choose a reason for hiding this comment

SEOKKAMONI Jul 13, 2024

Choose a reason for hiding this comment

codspeed-hq bot commented Jul 13, 2024 • edited Loading

CodSpeed Performance Report

Merging #1074 will create unknown performance changes

Summary

codecov-commenter commented Jul 13, 2024 • edited Loading

Codecov Report

manudeli commented Jul 13, 2024

SEOKKAMONI commented Jul 13, 2024 •

edited by manudeli

Loading

changeset-bot bot commented Jul 13, 2024 •

edited

Loading

vercel bot commented Jul 13, 2024 •

edited

Loading

codspeed-hq bot commented Jul 13, 2024 •

edited

Loading

codecov-commenter commented Jul 13, 2024 •

edited

Loading