Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: add doc for shouldCatch prop #952

Closed
manudeli opened this issue Jun 19, 2024 · 2 comments · Fixed by #1085
Closed

[Feature]: add doc for shouldCatch prop #952

manudeli opened this issue Jun 19, 2024 · 2 comments · Fixed by #1085
Labels
@suspensive/react

Comments

@manudeli
Copy link
Member

Package Scope

@suspensive/react

Description

add doc for shouldCatch prop

Possible Solution

No response

etc.

No response
@manudeli manudeli assigned manudeli and gwansikk and unassigned manudeli Jun 19, 2024
@manudeli
Copy link
Member Author

manudeli commented Jul 13, 2024 •
edited
Loading

I see this Pull Request #1081
@jgjgill Could you make this doc please? I think you understood this shouldCatch prop

@jgjgill
Copy link
Contributor

jgjgill commented Jul 13, 2024

Oh, there was a related issue.
If I can help, I'd be happy to take it from there.
Thanks. 🙇‍♂️

@jgjgill jgjgill mentioned this issue Jul 14, 2024
Merged
1 task
manudeli added a commit that referenced this issue Aug 3, 2024
@jgjgill @manudeli
docs(suspensive.org): add docs for shouldCatch at ErrorBoundary (#1085
9b7a804 
)

# Overview

close #952 

Hi, I worked on the docs. 🧐
This is my first time adding docs to this library.
So please feel free to tell me if I'm missing anything.

Thanks for the opportunity. 🙇‍♂️

<!--
    A clear and concise description of what this pr is about.
 -->

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------

Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
manudeli pushed a commit that referenced this issue Aug 3, 2024
@jgjgill
docs(suspensive.org): add docs for shouldCatch at ErrorBoundary (#1085
fd71f87 
)

# Overview

close #952 

Hi, I worked on the docs. 🧐
This is my first time adding docs to this library.
So please feel free to tell me if I'm missing anything.

Thanks for the opportunity. 🙇‍♂️

<!--
    A clear and concise description of what this pr is about.
 -->

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------
manudeli added a commit that referenced this issue Aug 3, 2024
@jgjgill @manudeli
docs(suspensive.org): add docs for shouldCatch at ErrorBoundary (#1085
c72ea2a 
)

# Overview

close #952 

Hi, I worked on the docs. 🧐
This is my first time adding docs to this library.
So please feel free to tell me if I'm missing anything.

Thanks for the opportunity. 🙇‍♂️

<!--
    A clear and concise description of what this pr is about.
 -->

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------

Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
manudeli added a commit that referenced this issue Aug 3, 2024
@jgjgill @manudeli
docs(suspensive.org): add docs for shouldCatch at ErrorBoundary (#1085
16b400f 
)

# Overview

close #952 

Hi, I worked on the docs. 🧐
This is my first time adding docs to this library.
So please feel free to tell me if I'm missing anything.

Thanks for the opportunity. 🙇‍♂️

<!--
    A clear and concise description of what this pr is about.
 -->

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------

Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@suspensive/react
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(suspensive.org): add docs for shouldCatch at ErrorBoundary jgjgill/suspensive
3 participants
@gwansikk @manudeli @jgjgill