-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(suspensive.org): add docs for shouldCatch at ErrorBoundary
#1085
Conversation
π¦ Changeset detectedLatest commit: d8bd14c The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
@jgjgill is attempting to deploy a commit to the Toss Team on Vercel. A member of the Team first needs to authorize it. |
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #1085 +/- ##
=======================================
Coverage 84.23% 84.23%
=======================================
Files 54 54
Lines 552 552
Branches 117 118 +1
=======================================
Hits 465 465
Misses 82 82
Partials 5 5
|
CodSpeed Performance ReportMerging #1085 will create unknown performance changesComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jgjgill Thanks!! You made cool example too!
I left comments to improve some things
@manudeli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing to making this library easier! I'm glad that library users can now better understand and use the shouldCatch prop. π
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @suspensive/react@2.6.2 ### Patch Changes - [#1085](#1085) [`6848e8d`](6848e8d) Thanks [@jgjgill](https://github.com/jgjgill)! - fix(react): add jsdoc for shouldCatch prop of ErrorBoundary ## @suspensive/react-query@2.6.2 ### Patch Changes - Updated dependencies \[[`6848e8d`](6848e8d)]: - @suspensive/react@2.6.2 - @suspensive/react-query-4@2.6.2 - @suspensive/react-query-5@2.6.2 ## @suspensive/react-query-4@2.6.2 ### Patch Changes - Updated dependencies \[[`6848e8d`](6848e8d)]: - @suspensive/react@2.6.2 ## @suspensive/react-query-5@2.6.2 ### Patch Changes - Updated dependencies \[[`6848e8d`](6848e8d)]: - @suspensive/react@2.6.2 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
) # Overview close #952 Hi, I worked on the docs. π§ This is my first time adding docs to this library. So please feel free to tell me if I'm missing anything. Thanks for the opportunity. πββοΈ <!-- A clear and concise description of what this pr is about. --> ## PR Checklist - [x] I did below actions if need 1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md) 2. I added documents and tests. --------- Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @suspensive/react@2.6.2 ### Patch Changes - [#1085](#1085) [`6848e8d`](6848e8d) Thanks [@jgjgill](https://github.com/jgjgill)! - fix(react): add jsdoc for shouldCatch prop of ErrorBoundary ## @suspensive/react-query@2.6.2 ### Patch Changes - Updated dependencies \[[`6848e8d`](6848e8d)]: - @suspensive/react@2.6.2 - @suspensive/react-query-4@2.6.2 - @suspensive/react-query-5@2.6.2 ## @suspensive/react-query-4@2.6.2 ### Patch Changes - Updated dependencies \[[`6848e8d`](6848e8d)]: - @suspensive/react@2.6.2 ## @suspensive/react-query-5@2.6.2 ### Patch Changes - Updated dependencies \[[`6848e8d`](6848e8d)]: - @suspensive/react@2.6.2 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
) # Overview close #952 Hi, I worked on the docs. π§ This is my first time adding docs to this library. So please feel free to tell me if I'm missing anything. Thanks for the opportunity. πββοΈ <!-- A clear and concise description of what this pr is about. --> ## PR Checklist - [x] I did below actions if need 1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md) 2. I added documents and tests. ---------
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @suspensive/react@2.6.2 ### Patch Changes - [#1085](#1085) [`6848e8d`](6848e8d) Thanks [@jgjgill](https://github.com/jgjgill)! - fix(react): add jsdoc for shouldCatch prop of ErrorBoundary ## @suspensive/react-query@2.6.2 ### Patch Changes - Updated dependencies \[[`6848e8d`](6848e8d)]: - @suspensive/react@2.6.2 - @suspensive/react-query-4@2.6.2 - @suspensive/react-query-5@2.6.2 ## @suspensive/react-query-4@2.6.2 ### Patch Changes - Updated dependencies \[[`6848e8d`](6848e8d)]: - @suspensive/react@2.6.2 ## @suspensive/react-query-5@2.6.2 ### Patch Changes - Updated dependencies \[[`6848e8d`](6848e8d)]: - @suspensive/react@2.6.2
) # Overview close #952 Hi, I worked on the docs. π§ This is my first time adding docs to this library. So please feel free to tell me if I'm missing anything. Thanks for the opportunity. πββοΈ <!-- A clear and concise description of what this pr is about. --> ## PR Checklist - [x] I did below actions if need 1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md) 2. I added documents and tests. --------- Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @suspensive/react@2.6.2 ### Patch Changes - [#1085](#1085) [`6848e8d`](6848e8d) Thanks [@jgjgill](https://github.com/jgjgill)! - fix(react): add jsdoc for shouldCatch prop of ErrorBoundary ## @suspensive/react-query@2.6.2 ### Patch Changes - Updated dependencies \[[`6848e8d`](6848e8d)]: - @suspensive/react@2.6.2 - @suspensive/react-query-4@2.6.2 - @suspensive/react-query-5@2.6.2 ## @suspensive/react-query-4@2.6.2 ### Patch Changes - Updated dependencies \[[`6848e8d`](6848e8d)]: - @suspensive/react@2.6.2 ## @suspensive/react-query-5@2.6.2 ### Patch Changes - Updated dependencies \[[`6848e8d`](6848e8d)]: - @suspensive/react@2.6.2
) # Overview close #952 Hi, I worked on the docs. π§ This is my first time adding docs to this library. So please feel free to tell me if I'm missing anything. Thanks for the opportunity. πββοΈ <!-- A clear and concise description of what this pr is about. --> ## PR Checklist - [x] I did below actions if need 1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md) 2. I added documents and tests. --------- Co-authored-by: Jonghyeon Ko <jonghyeon@toss.im>
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @suspensive/react@2.6.2 ### Patch Changes - [#1085](#1085) [`6848e8d`](6848e8d) Thanks [@jgjgill](https://github.com/jgjgill)! - fix(react): add jsdoc for shouldCatch prop of ErrorBoundary ## @suspensive/react-query@2.6.2 ### Patch Changes - Updated dependencies \[[`6848e8d`](6848e8d)]: - @suspensive/react@2.6.2 - @suspensive/react-query-4@2.6.2 - @suspensive/react-query-5@2.6.2 ## @suspensive/react-query-4@2.6.2 ### Patch Changes - Updated dependencies \[[`6848e8d`](6848e8d)]: - @suspensive/react@2.6.2 ## @suspensive/react-query-5@2.6.2 ### Patch Changes - Updated dependencies \[[`6848e8d`](6848e8d)]: - @suspensive/react@2.6.2
Overview
close #952
Hi, I worked on the docs. π§
This is my first time adding docs to this library.
So please feel free to tell me if I'm missing anything.
Thanks for the opportunity. πββοΈ
PR Checklist