Combining maxDaysToShow, maxEventCount and showNoEventDays does not work as expected

[vandernorth]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

Relevant config:

maxDaysToShow: 5
maxEventCount: 1 # would normally be more, but is better for this bug report
showNoEventDays: true
showHiddenText: true
noEventText: NO EVENTS
hiddenEventText: HIDDEN EVENTS

When combining these settings: Days that have events filtered out because it goes over the maxEventCount will show as "No events".

Expected behaviour

I would expect one of:

1. These days not to be shown at all (because the settings is called MAXdaysToShow)
2. These days to show HIDDEN EVENTS

I would prefer option 1.

Steps To Reproduce

v9.1.0 on HASS 2023.10.0

Use the above config to reproduce, play with maxEventCount a bit.

Mode

Event (default)

Card Version

9.1.0

Home Assistant Version

2023.10.0

Configuration

maxDaysToShow: 5
maxEventCount: 1
showNoEventDays: true
showHiddenText: true
noEventText: NO EVENTS
hiddenEventText: HIDDEN EVENTS

Relevant log output

None

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

Hello @vandernorth, thank you for your interest in our work!
If this is a bug report, please provide your configuration and any screenshots that would assist troubleshooting, otherwise we can not help you.

[vandernorth]

I did.

[Tosko4]

I have the same issue, when I say maxDaysToShow: 14 the list is quite long, when i combine it with maxEventCount: 8, it does not show the calendar items of tomorrow.

[dave-dube]

Same issue on my side. I'm using it with 3 calendars (each has several events), and when using maxDaysToShow +maxEventCount it doesn't show right events. It shows the right number of event according the maxEventCount setting (eg: 10), but those 10 event are only considering "all day events" from 18 days ahead.. weird. Like a wrong sorting action is done prior to filter out events exceeding the maxEventCount. So for now. no choice to stop using maxEventCount because my dashboard skip a lot of events.

[johnekarlsson]

Same issue for me. The more I increase maxDaysToShow, the more events are skipped, (although always considering the maxEventCount). The selection of what events are shown is not chronological, as expected, but seemingly random.

[marksie1988]

Ok so the hidden event text not showing was due to it accidentally being removed at some point when code was re-structured. I have now added that back in so at least you know events are hidden. the issue with the way hidden events is calculated is that its not per day, it counts the total events that were removed from the list of events when limits are applied. This means that although it will tell you x events hidden it wont tell you how many on which day.

I could look at modifying the "No Events" so that it doesnt show when there are hidden events?

[marksie1988]

I have released a new beta that fixes the hidden events text v9.2.1-beta.3

[johnekarlsson]

Hi! I have updated to beta.4 now and the issue still persists of seemingly random events being hidden. I'd be glad to assist in troubleshooting or answering questions if there are any!

[marksie1988]

@johnekarlsson do you have a copy of your config so I can check if it's something specific with the way you have the config.

I'm not sure why the events hidden would be random as it takes the current day + startDaysAhead + maxDaysToShow it then pulls all the events between this sorts them in the order selected and then removes X number of events from the bottom of the list.

As it removes the events at the end it should always be consistent. The only thing that would amend this is if an event finished as then it would be moved to the end of the list which would mean it would be hidden and one of the events that hasn't finished would be shown.

[johnekarlsson]

Here you go!

With the config below I get these events:

But if I remove "maxDaysToShow: 30" I can now see three events that were hidden before (two the 15th and one the 17th).

type: custom:atomic-calendar-revive
entities:
  - entity: calendar.xxxxxx
    titleColor: red
name: null
enableModeChange: true
firstDayOfWeek: 1
maxDaysToShow: 30
showNoEventsForToday: false
showLastCalendarWeek: false
showProgressBar: false
disableLocationLink: false
showFullDayProgress: false
europeanDate: true
showEventIcon: false
showHiddenText: false
showLoader: false
showDate: false
sortByStartTime: false
hideFinishedEvents: true
showLocation: false
showRelativeTime: false
fullDayEventText: Hela dagen
untilText: till
noEventsForNextDaysText: Inga aktiviteter de kommande dagarna
noEventText: Inga aktiviteter idag
calShowDescription: false
disableCalEventLink: true
disableCalLocationLink: true
disableCalLink: true
dimFinishedEvents: true
disableEventLink: true
showWeekDay: false
language: sv
showMonth: true
showCurrentEventLine: false
maxEventCount: 6

[marksie1988]

Ok thanks I'll do some testing tomorrow,

How many events are on each of those days? And are there any full day events or are they all timed events?

This will allow me to totally replicate your expected view Vs the incorrect view.

[vandernorth]

Using v9.4.0 the issue seems to be resolved. at least for what is was trying to do.
johnekarlsson everything working on your end as well?

[johnekarlsson]

Hi,

I still have a problem, but I suspect it's more related to #1378. In any case, it's a bit har for me to troubleshoot this when #1378 is still open.

The following is tested using 9.4.0 Beta 2

This code:

type: custom:atomic-calendar-revive
entities:
  - entity: calendar.xxx
maxDaysToShow: 30

...gives this result (works as expected):

But if I add:
maxEventCount: 6

...many events are hidden that shouldn't be:

[marksie1988]

I'm working on a fix after I realised what I was doing wrong...

The all day events were being placed at the begining of the array, but the regular events on the same dates were being pushed down.

I'm now reworking the logic so that each day is sorted individually and then all merged into one at the end which should solve this.

[github-actions]

🎉 This issue has been resolved in version 9.4.0-beta.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[marksie1988]

Hopefully this latest release resolves issues with sorting, there is still an issue with milestone sorting but that will be more complex to resolve

[johnekarlsson]

It works! All issues resolved. Thanks' alot! Den tis 23 jan. 2024 kl 10:36 skrev Steven Marks ***@***.***>:

…

Hopefully this latest release resolves issues with sorting, there is still an issue with milestone sorting but that will be more complex to resolve — Reply to this email directly, view it on GitHub <#1247 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APD2WAGSQR4KIC65BEV5WRLYP6AADAVCNFSM6AAAAAA6LVLJL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBVGY2TKNJUGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[github-actions]

🎉 This issue has been resolved in version 9.5.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[github-actions]

🎉 This issue has been resolved in version 9.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀