finished Events are not sorted correctly #1258

sevorl · 2023-10-30T10:06:36Z

Is there an existing issue for this?

I have searched the existing issues

Current Behavior

Finished events used to be at the top of the event list when "softBy: start"
This is no longer the case.

Instead, the finished events are "somewhere" in the list
See screenshot, finished Events are dimmed

Expected behaviour

Finished Events should be at the top of the list

Steps To Reproduce

display a calendar with the configuration I pasted in "Configuration".

Mode

Event (default)

Card Version

v.9.2.0

Home Assistant Version

2023.10

Configuration

type: custom:atomic-calendar-revive
enableModeChange: true
entities:
  - entity: calendar.stundenplan_jakob
    name: Stundenplan Jakob
    blocklist: (Pause)|(Sport)|(Schwimmen)

firstDayOfWeek: 1
descLength: 10
defaultMode: Event
hideFinishedEvents: false
showRelativeTime: false
showLocation: false
sortByStartTime: true
showDate: false
hideDuplicates: true
europeanDate: true
showCurrentEventLine: true
showMonth: false
showProgressBar: true
showWeekDay: true
disableEventLink: true
showNoEventsForToday: false
showNoEventDays: true
showFullDayProgress: false
ShowDescription: false
showLastCalendarWeek: false
showEventIcon: false
dimFinishedEvents: true
showHiddenText: false
showDescription: false
untilText: bis
noEventText: Keine Schule
noEventsForTodayText: Nichts mehr zu tun. Auch schön
showLoader: false
noEventsForNextDaysText: Keine Termine in den nächsten Tagen
fullDayEventText: ' '
softLimit: true
maxDaysToShow: 8
calShowDescription: false
eventTitleSize: 100
refreshInterval: 120
dateFormat: dddd, D. MMMM
cardHeight: calc(100vh - 15em)
disableCalLink: true
hoursOnSameLine: true

Relevant log output

No response

Code of Conduct

I agree to follow this project's Code of Conduct

github-actions · 2023-10-30T10:07:12Z

Hello @sevorl, thank you for your interest in our work!
If this is a bug report, please provide your configuration and any screenshots that would assist troubleshooting, otherwise we can not help you.

sevorl · 2023-10-30T13:46:39Z

I was able to boil this down to a much simpler configuration
See screenshot.

It seams like the finished events are sorted backwards.

I removed all configuration except the bare minimum:

type: custom:atomic-calendar-revive
enableModeChange: true
entities:

entity: calendar.stundenplan_jakob
name: Stundenplan Jakob

finished events are grey.

Screenshot was taken at 14:47

I would expect the finished event "Erzählkreis" to be on top of the list.
The behaviour changed with the last update.

Xento · 2023-10-30T15:44:19Z

I think I have the same issue:

marksie1988 · 2023-11-13T22:08:45Z

Please upgrade to the latest beta, v9.2.1-beta.1 I think this will be fixed as part of #1248, I will also test to confirm

marksie1988 · 2023-11-13T22:21:20Z

Ok done a test and still doesnt seem to fix it, i will take a look at this soon to resolve in next beta.

sevorl · 2023-11-15T14:29:10Z

I tested as well and have to agree with @marksie1988 : it is not fixed in v9.2.1-beta.1

I (accidentially) downloaded 9.20-betat.1 first - this works fine.

But v9.2.1-beta.1 does not solve this.

ajobbins · 2023-11-23T02:07:00Z

Confirming the same issue and that v9.2.1-beta.1 didn't resolve it

remcodj · 2023-11-27T18:29:00Z

Same here on HA 2023.11.1 and Atomic Calendar Revive 9.2.0

sevorl · 2023-12-06T13:00:48Z

any update on this?

j0dan · 2023-12-08T02:34:40Z

Seems to be broken since 9.0.2

## [9.2.1-beta.2](v9.2.1-beta.1...v9.2.1-beta.2) (2024-01-05) ### Bug Fixes * localized dates not showing as expected when using LL etc ([432f0f2](432f0f2)), closes [#1334](#1334) * **sortby:** resolves issue with sorting of events ([051d2ca](051d2ca)), closes [#1258](#1258)

github-actions · 2024-01-05T12:15:26Z

🎉 This issue has been resolved in version 9.2.1-beta.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

marksie1988 · 2024-01-05T13:11:23Z

Hi All,

I have just released a new beta, my testing shows this as resolved, please let me know your outcome

sevorl · 2024-01-08T07:53:56Z

Hi marksie, I just installed v9.2.1-beta.2.
Unfortumately, the issue remains. It does not seem to be fixed yet.

sevorl · 2024-01-08T08:02:44Z

Here is a screenshot:

fix #1258

## [9.2.1-beta.3](v9.2.1-beta.2...v9.2.1-beta.3) (2024-01-12) ### Bug Fixes * hidden events text was not showing up ([844f98b](844f98b)) * **sortby:** hopefully actually resolves sortby this time! ([cdf06f3](cdf06f3)), closes [#1258](#1258)

github-actions · 2024-01-12T17:23:01Z

🎉 This issue has been resolved in version 9.2.1-beta.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [9.3.0](v9.2.1...v9.3.0) (2024-01-13) ### Features * **lang:** add Czech ([47d284e](47d284e)), closes [#1363](#1363) ### Bug Fixes * bug introduced when fixing hidden event text ([ee8d280](ee8d280)) * entity.maxDaysToShow was not applying ([16b7fbb](16b7fbb)), closes [#1255](#1255) [#1247](#1247) * hidden events text was not showing up ([844f98b](844f98b)) * localized dates not showing as expected when using LL etc ([432f0f2](432f0f2)), closes [#1334](#1334) * **sortby:** hopefully actually resolves sortby this time! ([cdf06f3](cdf06f3)), closes [#1258](#1258) * **sortby:** resolves issue with sorting of events ([051d2ca](051d2ca)), closes [#1258](#1258)

github-actions · 2024-01-13T21:34:46Z

🎉 This issue has been resolved in version 9.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

sevorl · 2024-01-15T11:23:33Z

This is still not resolved. This issue is still open, sorting is not correct. past items are at the bottom, current items are on top.

marksie1988 · 2024-01-15T11:54:38Z

Yes that is correct, I had put some code in the wrong area, moved that in the latest and will do a beta release shortly

fix #1258

## [9.3.0-beta.2](v9.3.0-beta.1...v9.3.0-beta.2) (2024-01-15) ### Features * **calendar:** added weekendSat, weekendSun and differentMonth classes ([0a86dad](0a86dad)), closes [#1362](#1362) ### Bug Fixes * finished events sorted by start were shown at the bottom ([c52f95c](c52f95c)), closes [#1258](#1258)

github-actions · 2024-01-15T11:57:19Z

🎉 This issue has been resolved in version 9.3.0-beta.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

sevorl · 2024-01-15T12:27:45Z

just tested in v9.3.0-beta.3. Looking good now!
Thanks for all the effort you put into this great calendar!

* build(deps-dev): bump @babel/core from 7.23.6 to 7.23.7 Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.23.6 to 7.23.7. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.7/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps-dev): bump @babel/plugin-proposal-decorators Bumps [@babel/plugin-proposal-decorators](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-proposal-decorators) from 7.23.6 to 7.23.7. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.7/packages/babel-plugin-proposal-decorators) --- updated-dependencies: - dependency-name: "@babel/plugin-proposal-decorators" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps-dev): bump @babel/preset-env from 7.23.6 to 7.23.8 Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.23.6 to 7.23.8. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.8/packages/babel-preset-env) --- updated-dependencies: - dependency-name: "@babel/preset-env" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps-dev): bump @typescript-eslint/eslint-plugin Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 6.15.0 to 6.18.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.18.1/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump lit from 3.1.0 to 3.1.1 Bumps [lit](https://github.com/lit/lit/tree/HEAD/packages/lit) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/lit/lit/releases) - [Changelog](https://github.com/lit/lit/blob/main/packages/lit/CHANGELOG.md) - [Commits](https://github.com/lit/lit/commits/lit@3.1.1/packages/lit) --- updated-dependencies: - dependency-name: lit dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps-dev): bump eslint-plugin-prettier from 5.1.1 to 5.1.3 Bumps [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier) from 5.1.1 to 5.1.3. - [Release notes](https://github.com/prettier/eslint-plugin-prettier/releases) - [Changelog](https://github.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md) - [Commits](prettier/eslint-plugin-prettier@v5.1.1...v5.1.3) --- updated-dependencies: - dependency-name: eslint-plugin-prettier dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump @lit/reactive-element from 2.0.2 to 2.0.3 Bumps [@lit/reactive-element](https://github.com/lit/lit/tree/HEAD/packages/reactive-element) from 2.0.2 to 2.0.3. - [Release notes](https://github.com/lit/lit/releases) - [Changelog](https://github.com/lit/lit/blob/main/packages/reactive-element/CHANGELOG.md) - [Commits](https://github.com/lit/lit/commits/@lit/reactive-element@2.0.3/packages/reactive-element) --- updated-dependencies: - dependency-name: "@lit/reactive-element" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps-dev): bump rollup from 4.9.1 to 4.9.5 Bumps [rollup](https://github.com/rollup/rollup) from 4.9.1 to 4.9.5. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v4.9.1...v4.9.5) --- updated-dependencies: - dependency-name: rollup dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * docs: added styling pages * feat(calendar): added weekendSat, weekendSun and differentMonth classes closes #1362 * fix: finished events sorted by start were shown at the bottom fix #1258 * chore(release): 9.3.0-beta.2 [skip ci] ## [9.3.0-beta.2](v9.3.0-beta.1...v9.3.0-beta.2) (2024-01-15) ### Features * **calendar:** added weekendSat, weekendSun and differentMonth classes ([0a86dad](0a86dad)), closes [#1362](#1362) ### Bug Fixes * finished events sorted by start were shown at the bottom ([c52f95c](c52f95c)), closes [#1258](#1258) * fix: all day events not sorting correctly fix #1338 * chore(release): 9.3.0-beta.3 [skip ci] ## [9.3.0-beta.3](v9.3.0-beta.2...v9.3.0-beta.3) (2024-01-15) ### Bug Fixes * all day events not sorting correctly ([7075d4c](7075d4c)), closes [#1338](#1338) * build(deps-dev): bump @typescript-eslint/parser from 6.15.0 to 6.18.1 Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 6.15.0 to 6.18.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.18.1/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * fix(locale): in some sitiatuins the locale would not be applied fixes #1361 * chore(release): 9.3.0-beta.4 [skip ci] ## [9.3.0-beta.4](v9.3.0-beta.3...v9.3.0-beta.4) (2024-01-19) ### Bug Fixes * **locale:** in some sitiatuins the locale would not be applied ([d10c655](d10c655)), closes [#1361](#1361) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>

## [9.4.0-beta.1](v9.3.0...v9.4.0-beta.1) (2024-01-20) ### Features * **calendar:** added weekendSat, weekendSun and differentMonth classes ([0a86dad](0a86dad)), closes [#1362](#1362) ### Bug Fixes * all day events not sorting correctly ([7075d4c](7075d4c)), closes [#1338](#1338) * finished events sorted by start were shown at the bottom ([c52f95c](c52f95c)), closes [#1258](#1258) * **locale:** in some sitiatuins the locale would not be applied ([d10c655](d10c655)), closes [#1361](#1361) * missing comma in de.json causing build errors ([593d103](593d103))

## [9.4.0](v9.3.0...v9.4.0) (2024-01-20) ### Features * **calendar:** added weekendSat, weekendSun and differentMonth classes ([0a86dad](0a86dad)), closes [#1362](#1362) ### Bug Fixes * all day events not sorting correctly ([7075d4c](7075d4c)), closes [#1338](#1338) * finished events sorted by start were shown at the bottom ([c52f95c](c52f95c)), closes [#1258](#1258) * **locale:** in some sitiatuins the locale would not be applied ([d10c655](d10c655)), closes [#1361](#1361) * missing comma in de.json causing build errors ([593d103](593d103))

github-actions · 2024-01-20T18:07:35Z

🎉 This issue has been resolved in version 9.4.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions · 2024-01-20T18:08:07Z

🎉 This issue has been resolved in version 9.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

sevorl added the type/bug Something isn't working label Oct 30, 2023

github-actions bot added the released on @beta label Jan 5, 2024

marksie1988 added a commit that referenced this issue Jan 12, 2024

fix(sortby): hopefully actually resolves sortby this time!

cdf06f3

fix #1258

marksie1988 closed this as completed in 051d2ca Jan 13, 2024

github-actions bot added the released label Jan 13, 2024

marksie1988 added a commit that referenced this issue Jan 15, 2024

fix: finished events sorted by start were shown at the bottom

c52f95c

fix #1258

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

finished Events are not sorted correctly #1258

finished Events are not sorted correctly #1258

sevorl commented Oct 30, 2023

github-actions bot commented Oct 30, 2023

sevorl commented Oct 30, 2023 •

edited

Loading

Xento commented Oct 30, 2023

marksie1988 commented Nov 13, 2023

marksie1988 commented Nov 13, 2023

sevorl commented Nov 15, 2023 •

edited

Loading

ajobbins commented Nov 23, 2023

remcodj commented Nov 27, 2023

sevorl commented Dec 6, 2023

j0dan commented Dec 8, 2023

github-actions bot commented Jan 5, 2024

marksie1988 commented Jan 5, 2024

sevorl commented Jan 8, 2024

sevorl commented Jan 8, 2024

github-actions bot commented Jan 12, 2024

github-actions bot commented Jan 13, 2024

sevorl commented Jan 15, 2024

marksie1988 commented Jan 15, 2024

github-actions bot commented Jan 15, 2024

sevorl commented Jan 15, 2024

github-actions bot commented Jan 20, 2024

github-actions bot commented Jan 20, 2024

finished Events are not sorted correctly #1258

finished Events are not sorted correctly #1258

Comments

sevorl commented Oct 30, 2023

Is there an existing issue for this?

Current Behavior

Expected behaviour

Steps To Reproduce

Mode

Card Version

Home Assistant Version

Configuration

Relevant log output

Code of Conduct

github-actions bot commented Oct 30, 2023

sevorl commented Oct 30, 2023 • edited Loading

Xento commented Oct 30, 2023

marksie1988 commented Nov 13, 2023

marksie1988 commented Nov 13, 2023

sevorl commented Nov 15, 2023 • edited Loading

ajobbins commented Nov 23, 2023

remcodj commented Nov 27, 2023

sevorl commented Dec 6, 2023

j0dan commented Dec 8, 2023

github-actions bot commented Jan 5, 2024

marksie1988 commented Jan 5, 2024

sevorl commented Jan 8, 2024

sevorl commented Jan 8, 2024

github-actions bot commented Jan 12, 2024

github-actions bot commented Jan 13, 2024

sevorl commented Jan 15, 2024

marksie1988 commented Jan 15, 2024

github-actions bot commented Jan 15, 2024

sevorl commented Jan 15, 2024

github-actions bot commented Jan 20, 2024

github-actions bot commented Jan 20, 2024

sevorl commented Oct 30, 2023 •

edited

Loading

sevorl commented Nov 15, 2023 •

edited

Loading