Don't initialize BaseFileLock when just returning existing instance #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborbernat
approved these changes
Jun 11, 2024
|
This (via the 3.15.0 release) may be responsible for breaking virtualenv. See pypa/virtualenv#2735. |
|
Ah this is API breaking ( |
|
OK sorry, can fix - just need to put in a dummy |
|
Doesn't sound like an awesome idea to me because type safety is out the window. Sounds like a test that subclasses and overrides |
|
Nevermind, I see that's already been done! Many thanks! |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #331. Avoids re-initializing a
FileLockorBaseFileLockifis_singletonis true and__new__just returns the singleton, which allows the lock to be re-acquired via the constructor if it has already been acquired without resetting the count.