Hotfix: Restore __init__ method; more robust initialization for singleton locks #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
… init-signature-fix
for more information, see https://pre-commit.ci
… init-signature-fix
for more information, see https://pre-commit.ci
tamird
reviewed
Jun 12, 2024
|
Will add a test for this as well. |
kwist-sgr
reviewed
Jun 12, 2024
|
Sorry for this mess. I understand if you want to take longer to review this time; did not realize so much infrastructure relies on this package. |
No worries All good. |
ethanbb
changed the title
gaborbernat
requested changes
Jun 12, 2024
stasfilin
reviewed
Jun 12, 2024
|
I had this test failure on |
Never mind, got it |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with subclassing brought up in pypa/virtualenv#2735 (discussed in #334)