Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/フォーム内に入る / 入りそうなボタンに type="button" を付ける #270

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

anko9801
Copy link
Contributor

@anko9801 anko9801 commented Aug 28, 2024

User description

fix: #231


PR Type

Bug fix


Description

  • 各コンポーネント内のボタンにtype="button"を追加し、フォーム送信を防止。
  • NewRequestFileForm.vueNewRequestTargets.vueNewTransactionTarget.vueRequestFiles.vueFloatingMenu.vueInputSelectSingle.vueMarkdownTextarea.vueの各ファイルで修正を実施。

Changes walkthrough 📝

Relevant files
Bug fix
NewRequestFileForm.vue
Add type attribute to button in NewRequestFileForm             

src/components/newRequest/NewRequestFileForm.vue

  • type="button" added to a button element.
+1/-0     
NewRequestTargets.vue
Add type attribute to button in NewRequestTargets               

src/components/newRequest/NewRequestTargets.vue

  • type="button" added to a button element.
+1/-0     
NewTransactionTarget.vue
Add type attribute to button in NewTransactionTarget         

src/components/newTransaction/NewTransactionTarget.vue

  • type="button" added to a button element.
+1/-0     
RequestFiles.vue
Add type attribute to button in RequestFiles                         

src/components/requestDetail/RequestFiles.vue

  • type="button" added to a button element.
+1/-0     
FloatingMenu.vue
Add type attribute to button in FloatingMenu                         

src/components/shared/FloatingMenu.vue

  • type="button" added to a button element.
+1/-0     
InputSelectSingle.vue
Add type attribute to buttons in InputSelectSingle             

src/components/shared/InputSelectSingle.vue

  • type="button" added to multiple button elements.
+2/-1     
MarkdownTextarea.vue
Add type attribute to buttons in MarkdownTextarea               

src/components/shared/MarkdownTextarea.vue

  • type="button" added to multiple button elements.
+2/-0     

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No key issues to review

@anko9801 anko9801 requested a review from reiroop August 30, 2024 20:03
Copy link
Contributor

@reiroop reiroop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!

@anko9801 anko9801 merged commit 0ad9ac3 into main Aug 31, 2024
6 checks passed
@anko9801 anko9801 deleted the fix/type_button branch August 31, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

申請と入出金作成ページでbuttonにtype='button'をつける
2 participants