Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove onMounted fetchMe on App.vue #272

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

mehm8128
Copy link
Contributor

@mehm8128 mehm8128 commented Aug 29, 2024

User description

fix https://q.trap.jp/messages/01919ce8-9e20-7454-8245-11998a107511
fetchが早すぎて変なデータを取ってきていたので適当に消してみたら動いたのでこれでよさそうです(meのデータ自体はちょっと下のwatch内で取れてる)


PR Type

bug_fix


Description

  • onMounted lifecycle hook was removed from App.vue to prevent premature data fetching.
  • The call to useFetchMeUsecase was eliminated from onMounted, as it was fetching incorrect data.
  • The import statement for onMounted was removed, simplifying the code.

Changes walkthrough 📝

Relevant files
Bug fix
App.vue
Remove `onMounted` lifecycle hook and fetch call                 

src/App.vue

  • Removed onMounted lifecycle hook.
  • Eliminated the call to useFetchMeUsecase within onMounted.
  • Simplified imports by removing onMounted.
  • +1/-5     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Key issues to review

    ロジックの変更
    onMounted でのデータフェッチを削除し、watch に依存する形に変更しました。この変更がアプリケーションの他の部分にどのような影響を与えるか検討する必要があります。

    @reiroop reiroop merged commit bfd6d82 into main Aug 30, 2024
    7 checks passed
    @reiroop reiroop deleted the fix/remove-onMounted-fetchMe branch August 30, 2024 03:59
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants