Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/ヘルプリンクの追加 #298

Merged
merged 4 commits into from
Dec 24, 2024
Merged

feat/ヘルプリンクの追加 #298

merged 4 commits into from
Dec 24, 2024

Conversation

anko9801
Copy link
Contributor

@anko9801 anko9801 commented Sep 18, 2024

fix: #108
とりあえず仮のリンクをおいておく

Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Key issues to review

Accessibility Concern
ヘルプリンクにaria-label属性が追加されていないため、スクリーンリーダーを使用しているユーザーにとってアクセシビリティが低下しています。リンクの目的を明確にするために、適切なラベルを提供することをお勧めします。

@anko9801 anko9801 requested a review from reiroop December 21, 2024 11:04
Copy link
Contributor

@reiroop reiroop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!

@anko9801 anko9801 merged commit 192d846 into main Dec 24, 2024
6 checks passed
@anko9801 anko9801 deleted the feat/help_link branch December 24, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ヘルプリンクを置く
2 participants