You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: This suggestion addresses a critical bug where dereferencing a nil pointer could cause a panic. Adding a nil check is essential to ensure the stability of the code.
Why: The suggestion is crucial as it prevents a potential panic by adding a nil check before asserting the length, ensuring the test does not fail unexpectedly.
Why: The suggestion correctly identifies a potential bug where mock expectations are set regardless of the flags' values, which could lead to unintended mock calls. Implementing the suggestion would prevent this issue.
Why: This suggestion addresses a potential security issue by ensuring that unauthenticated users cannot access all game information, which is crucial for maintaining data privacy.
Why: Strengthening access control for unauthenticated users is important for security, ensuring that sensitive information is not exposed inadvertently.
Why: Setting a default value for game visibility can improve code robustness by ensuring that a default visibility is applied when none is explicitly set. However, the suggestion lacks specific implementation details for the default value.
sess, err := common.NewSession(mockConf)
if err != nil {
- t.Fatalf("failed to create session: %v", err)+ t.Error("failed to create session:", err)
return
}
Suggestion importance[1-10]: 7
Why: Changing t.Fatalf to t.Error allows the test suite to continue running other tests even if one fails, which can provide more comprehensive test results. However, it may not be suitable for all scenarios where immediate termination is desired.
err = json.NewDecoder(rec.Body).Decode(&res)
if err != nil {
- t.Fatalf("failed to decode response: %v", err)+ t.Error("failed to decode response:", err)+ return
}
Suggestion importance[1-10]: 7
Why: Adding error handling with t.Error instead of t.Fatalf allows the test to continue running, which can be beneficial for identifying multiple issues in a single test run. However, it may not be suitable if immediate termination is required.
Why: While the suggestion enhances the code by adding validation for sort types, it addresses a potential issue rather than a critical bug. It improves robustness but is not immediately necessary for functionality.
if errors.Is(err, values.ErrGameGenreNameEmpty) {
- return echo.NewHTTPError(http.StatusBadRequest, "game genre name is empty")+ return echo.NewHTTPError(http.StatusBadRequest, "ジャンル名が空です")
}
if errors.Is(err, values.ErrGameGenreNameTooLong) {
- return echo.NewHTTPError(http.StatusBadRequest, "game genre name is too long")+ return echo.NewHTTPError(http.StatusBadRequest, "ジャンル名が長すぎます")
}
if err != nil {
- log.Printf("failed to validate game genre name: %v\n", genreName)- return echo.NewHTTPError(http.StatusInternalServerError, "failed to validate game genre name")-}+ log.Printf("ジャンル名の検証に失敗しました: %v\n", genreName)+ return echo.NewHTTPError(http.StatusInternalServerError, "ジャンル名の検証に失敗しました")
Suggestion importance[1-10]: 5
Why: Improving error messages enhances user experience by making it easier to understand the cause of errors, but it is a minor enhancement in terms of functionality.
-_, err := strings.NewReader("invalid request body").WriteTo(reqBody)+_, err := strings.NewReader(`{"invalid": "request body"}`).WriteTo(reqBody)
if err != nil {
- t.Fatalf("failed to write to request body: %v", err)+ t.Error("failed to write to request body:", err)+ return
}
Suggestion importance[1-10]: 6
Why: The suggestion improves the readability and correctness of the test by using a valid JSON format for the request body, which aligns better with typical API request structures.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
APIの後方互換性の問題から新しいAPIをmainに入れられなかったが、APIの仕様を変えて互換性を保つようにしたので、入れても問題ない
PR Type
enhancement, tests
Description
CreateGame関数にジャンルの処理を追加し、ゲーム作成時のジャンル管理を強化。NotImplementedCheckerを追加し、未実装の可視性チェックを処理。Changes walkthrough 📝
2 files
game_test.go
ゲームの可視性とジャンルに関するテストの追加と更新src/handler/v2/game_test.go
game_genre_test.go
ゲームジャンルに関する新しいテスト関数の追加src/repository/gorm2/game_genre_test.go
TestGetGameGenresWithNames関数を追加TestSaveGameGenres関数を追加TestRegisterGenresToGame関数を追加2 files
game.go
ゲーム作成と取得におけるジャンルと可視性の処理追加src/service/v2/game.go
CreateGame関数にジャンルの処理を追加checker.go
可視性に関するチェッカーの追加src/handler/v2/checker.go
NotImplementedCheckerを追加47 files
v2_game_test.go
...src/repository/gorm2/v2_game_test.go
...
game_test.go
...src/service/v2/game_test.go
...
game_management_role_test.go
...src/repository/gorm2/game_management_role_test.go
...
game_genre_test.go
...src/handler/v2/game_genre_test.go
...
v2_game_version_test.go
...src/repository/gorm2/v2_game_version_test.go
...
v2_game.go
...src/repository/gorm2/v2_game.go
...
game.go
...src/handler/v2/game.go
...
wire_gen.go
...src/wire/wire_gen.go
...
game_genre_test.go
...src/service/v2/game_genre_test.go
...
v2_game_image_test.go
...src/repository/gorm2/v2_game_image_test.go
...
v2_game_video_test.go
...src/repository/gorm2/v2_game_video_test.go
...
game_genre.go
...src/handler/v2/game_genre.go
...
v2_game_file_test.go
...src/repository/gorm2/v2_game_file_test.go
...
game_genre.go
...src/repository/gorm2/game_genre.go
...
v11.go
...src/repository/gorm2/migrate/v11.go
...
v2_game.go
...src/service/v2_game.go
...
game_genre.go
...src/service/v2/game_genre.go
...
v13.go
...src/repository/gorm2/migrate/v13.go
...
v2_game.go
...src/repository/v2_game.go
...
v12.go
...src/repository/gorm2/migrate/v12.go
...
service.go
...src/wire/service.go
...
api.go
...src/handler/api.go
...
game_genre.go
...src/repository/game_genre.go
...
current.go
...src/repository/gorm2/migrate/current.go
...
repository.go
...src/wire/repository.go
...
handler.go
...src/wire/handler.go
...
game_image_test.go
...src/service/v2/game_image_test.go
...
game_genre.go
...src/service/game_genre.go
...
users_test.go
...src/handler/v2/users_test.go
...
game.go
...src/domain/game.go
...
game_version_test.go
...src/service/v2/game_version_test.go
...
game_image.go
...src/service/v2/game_image.go
...
v10.go
...src/repository/gorm2/migrate/v10.go
...
migrate.go
...src/repository/gorm2/migrate/migrate.go
...
game_version.go
...src/service/v2/game_version.go
...
errors.go
...src/repository/errors.go
...
game.go
...src/domain/values/game.go
...
v2_game_version.go
...src/repository/gorm2/v2_game_version.go
...
db.go
...src/repository/gorm2/db.go
...
errors.go
...src/service/errors.go
...
v2.yaml
...docs/openapi/v2.yaml
...
game_genre_relations.md
...docs/db_schema/game_genre_relations.md
...
README.md
...docs/db_schema/README.md
...
.tbls.yml
....tbls.yml
...
game_visibility_types.md
...docs/db_schema/game_visibility_types.md
...
games.md
...docs/db_schema/games.md
...
game_genres.md
...docs/db_schema/game_genres.md
...