Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Training plots are not clear #211

Closed
antimora opened this issue Mar 7, 2023 · 7 comments · Fixed by #790
Closed

Training plots are not clear #211

antimora opened this issue Mar 7, 2023 · 7 comments · Fixed by #790
Labels
enhancement Enhance existing features good first issue Good for newcomers help wanted Extra attention is needed

Comments

@antimora
Copy link
Collaborator

antimora commented Mar 7, 2023

Describe the bug

The plots are not clear and have too many dots.

To Reproduce
Run training of examples/mnist

Expected behavior
It would be if a different markers are used to plot.

Screenshots
image

Desktop (please complete the following information):

[~]$ uname -a
Darwin MacBook-Pro.local 22.3.0 Darwin Kernel Version 22.3.0: 
Mon Jan 30 20:38:37 PST 2023; root:xnu-8792.81.3~2/RELEASE_ARM64_T6000 arm64
[~]$ 
@antimora antimora changed the title Improve training plot output Training plots are not clear Mar 7, 2023
@antimora antimora added the enhancement Enhance existing features label Apr 2, 2023
@antimora antimora added help wanted Extra attention is needed good first issue Good for newcomers labels Apr 25, 2023
@NicBonetto
Copy link

Hey, I was browsing reddit and found this project when looking for a Rust project to contribute to. I would love to help out. Has this issue been resolved yet?

@antimora
Copy link
Collaborator Author

Hi @NicBonetto , welcome to the project.

This has not been resolved. Your contribution is highly appreciated.

I filed this ticket originally. I thought the training charts are not that clear and could be improved.

@nathanielsimard and I are here to review your changes or can talk on discord to ask for help.

@nathanielsimard
Copy link
Member

@NicBonetto Don't be afraid to come talk on Discord about how you want to tackle the issue; we can help. :)

@antimora
Copy link
Collaborator Author

antimora commented Jun 1, 2023

I think we should replace the textplot with termplot library because textplot is not updated anymore and uses nom version 1 which gives a warning when building burn.

@NicBonetto
Copy link

I've just started to play around with the examples, and may need some help with initial setup. Is this a good place to ask or should we move the discussions over to discord? (sorry in advanced if these are stupid questions).

@antimora
Copy link
Collaborator Author

antimora commented Jun 2, 2023

I've just started to play around with the examples, and may need some help with initial setup. Is this a good place to ask or should we move the discussions over to discord? (sorry in advanced if these are stupid questions).

Please do not worry about asking questions. We are all learning here and often we are not sure either.

I would recommend to try discord for back and worth questions/answers. We are all on it and it's not busy over there.

But I would suggest you keep updating the ticket to have a record of the discussion and new findings. It will help others learn as well.

@nathanielsimard
Copy link
Member

I think we should replace the current implementation with something like ratatui https://github.com/ratatui-org/ratatui. It would be better than the actual implementation and seems much more maintained, potentially avoiding security vulnerabilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhance existing features good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants