Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meval dependency requires nom==1.2.4 which will be deprecated in the future. #516

Closed
wdoppenberg opened this issue Jul 22, 2023 · 3 comments

Comments

@wdoppenberg
Copy link
Contributor

Describe the bug
During compilation, the following warning is emitted:

warning: the following packages contain code that will be rejected by a future version of Rust: nom v1.2.4

To Reproduce
Build the text-generation example.

Expected behavior
No warnings.

Desktop (please complete the following information):

  • OS: MacOS
@wdoppenberg
Copy link
Contributor Author

I just found your comment on the meval repository: rekka/meval-rs#30 .

Feel free to remove this issue if you deem it redundant

@antimora
Copy link
Collaborator

Thanks for filing. Yes, we are aware of the warning but it's good to have an open issue ticket, so it's keep it open.

This was brought it up in the existing issue to make the plot clear: #211 (comment)

We attempted (#485) to replace it with termplot which solved the warning issue but still the plots were not clear. We were thinking to remove plots console altogether and replace with something like tensorboard or CometML (see #382).

@antimora antimora added the housekeeping Housekeeping task label Jul 25, 2023
@antimora antimora removed the housekeeping Housekeeping task label Nov 20, 2023
@antimora
Copy link
Collaborator

I believe this is fixed now since we moved to a new text based training.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants