-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update plot rendering from textplots-rs to termplot #485
Conversation
I can confirm no compilation warning. I have run your changes locally on Mac M1 via vscode's term, the dots still appear as before. So your term must have a nicer fonts that render the dots differently. Maybe there is a setting in the library to adjust this somehow so an average user can see the plots clearly. Also there are RED/BLUE labels in " - {} RED: train | BLUE: valid \n{}", You mentioned on chat that you were going to try auto scaling for the plot, were you able to achieve it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't work with the text-accuracy example from my side, so maybe there is more work to be done before being merged.
.set_x_label("X-Axis: Iterations") | ||
.set_y_label("Y-Axis: Accuracy") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Y-Axis isn't always accuracy, it depends on the metric.
Closing this PR as burn-rs is moving away from console based plotting and instead will be using a proper dashboard in the future. |
Pull Request Template
Checklist
run-checks.sh
has been executed.Related Issues/PRs
This solves issue here: #211
Changes
Rendering of plots relied on
textplot-rs
which has a couple of issues:textplot-rts
has a dependency withnom
which causes a compilation warning when buildingburn
The changes made reflect the requirements for using
termplot
. The main two changes made:termplot
so all references to color have been removed.termplot
usesf64
values instead off32
values which were previously used. Conversions have been made where necessary.width
variable was of typeu32
but has been changed tousize
to matchheight
. Use ofusize
is better practice in this case as well.termplot
.Testing
Testing has been done by rendering plots for training data such as
mnist
example.