Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instrumentation): Add instrument support for HTTPX #2304

Conversation

ghost
Copy link

@ghost ghost commented Nov 16, 2024

Fixes #2283

  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.

TODOs/Questions:

  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change. Is this needed for this PR?
  • HTTPX instrumentor from OpenTelemetry does not support excluded URLs at the moment. Do you think we should open an issue there and push a fix?

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2024

CLA assistant check
All committers have signed the CLA.

@nirga
Copy link
Member

nirga commented Nov 19, 2024

Hey @whoiskrtk2, thanks! I was waiting for you to mark it as ready for review :)
Given the fact there isn't a way to exclude URLs - I'd at least test and see what spans we get for some of our test apps and put those screenshots here. And yes, we should open an issue there I think.

@ghost ghost closed this Dec 5, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Add instruments support for httpx
2 participants