PR review comments #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ventOfHitsProducer Pixel and strip hits are needed separately to avoid converting strip hits again when the support for initialStepPreSplitting will eventually be added. It also hides the question on naming (pixel vs strip vs outer).
makortel
force-pushed
the
mkfitFromPR33802
branch
from
31fb914 to
9fc3aec
Compare
|
This PR is again up to date |
|
cms-sw#33802 was merged so merging this PR here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR is collect commits to address the review comments in cms-sw#33802 on top of
CMSSW_11_2_0_mkFit_Xbranch.PR validation:
So far none.