add dead strips from strip quality #24
Conversation
|
link to mkFit PR: trackreco/mkFit#319 |
| deadvectors[ilay].push_back({surf.phiSpan().first,surf.phiSpan().second, | ||
| (isBarrel ? surf.zSpan().first : surf.rSpan().first),(isBarrel ? surf.zSpan().second : surf.rSpan().second)}); | ||
| } | ||
| mkfit::StdSeq::LoadDeads(hitWrapper.eventOfHits(), deadvectors); |
There was a problem hiding this comment.
I suppose this code would go in MkFitEventOfHitsProducer in trackreco/cmssw:mkFitIntegration.
There was a problem hiding this comment.
to be honest, I did not realize the branch I was using diverged from the main PR to central CMSSW. I am open to discuss what the best way to proceed is.
There was a problem hiding this comment.
Following the merge of #20 this PR should be rebased (or re-worked in MkFitEventOfHitsProducer.
There was a problem hiding this comment.
I can re-work it MkFitEventOfHitsProducer. What is the correct branch to use for development and for the PR?
There was a problem hiding this comment.
I have reworked the changes in MkFitEventOfHitsProducer:
CMSSW_11_2_0_mkFit_X...cerati:dead-modules-MkFitEventOfHitsProducer
I can close this PR and open a new one, please let me know. (However, looks like RecoTracker/MkFit/test/reco_cfg.py is currently broken, I am checking what is going on -- it complains about "No module named mkFitHitConverterDefault_cfi" maybe this is related to #20?)
There was a problem hiding this comment.
(was mkFitHitConverterDefault_cfi automatically created by RecoTracker/MkFit/plugins/MkFitHitConverter.cc? which has been removed in #20?)
There was a problem hiding this comment.
Certainly related to #20, I'll fix that, thanks. You can either force-push into your current dead-modules branch or create a new PR, whichever works.
There was a problem hiding this comment.
closing this PR, see #26
per Matti's suggestion Co-authored-by: Matti Kortelainen <matti.kortelainen@cern.ch>
PR description:
Gets input of dead modules from StripQuality event setup record to mkFit.
Notes / limitations:
PR validation:
http://uaf-10.t2.ucsd.edu/~cerati/deadmodules/