-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B-21427 & B-21430: Update & Populate Addresses is_oconus value #13849
B-21427 & B-21430: Update & Populate Addresses is_oconus value #13849
Conversation
migrations/app/schema/20241004203140_update_addresses_is_oconus.up.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are treating Alaska and Hawaii as OCONUS, we also need to set is_oconus to true for the state values of AK or HI in addition to just checking the country
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops picked the wrong one
migrations/app/schema/20241004203140_update_addresses_is_oconus.up.sql
Outdated
Show resolved
Hide resolved
conflicts |
migrations/app/schema/20241004203140_update_addresses_is_oconus.up.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussing via slack with Tevin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be able to add the is_oconus value to the various payload to model files to return that value along with the other values in the address object? Similar to how it was done for the market_code
I intentionally did not add it in any payload because I wasn't aware of any work or requirements that needed it and didn't want to return more data than what's needed. There was a story or the market_code to be returned because current work needed it. There isn't a story to return the is_oconus value on addresses. In my opinion if that is not needed at this time it would be best to create a story to do that so i can move on to getting the marketCode displayed on the cards. |
Ok. I'll need it for my BL for the internal API and we would probably need it for the office API as there is office user UB work upcoming |
Just pushed up a change returning Is_Oconus value where requested. |
migrations/app/schema/20241004203140_update_addresses_is_oconus.up.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested out and is_oconus
values are looking good!
B-21427
B-21430
Summary
This PR includes the following changes:
*At this time AK and HI is considered OCONUS
There are many areas throughout the mymove workflow and office workflow where an address is created and updated. It would be good to go through all workflows and make sure places where an address is updated or created works properly. is_oconus is not nullable so if an address is being created or updated without an is_oconus value it will throw an error.
Is there anything you would like reviewers to give additional scrutiny?
this article explains more about the approach used.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
*Note: AK and HI is considered OCONUS
How to test migration file
How to test on address creation
How to test on service item creation
How to test address update
Frontend
officeApp
class or custommin-width
styling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes:
Screenshots