-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B-21364 FF: UB shipments selectable for OCONUS duty locations #13917
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked great, code looks good, and the FF on the modal help tooltip is 🤌
Meets AC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked for me. Code reviewed. ACs look satisfied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agility ticket
Summary
The work here is to conditionally allow UB (Unaccompanied Baggage) shipments as selectable if either the origin or new duty locations are considered OCONUS. If at least one of the duty locations on the orders have an isOconus value of true, then we allow the customer to select UBs as a shipment type.
The selecting of UBs on the "How should this shipment move?" page IS feature flagged off.
There are upstreams of this story to pay attention to before merging into main:
B-21427 & B-21430: #13849
B-21365: #13878
B-21362 & B-21363: #13837
B-21481: This is NOT an upstream that impacts functionality/merge order, but does impact being able to test this in loadtest. This PR (21364) CAN go ahead of B-21481 as far as merge order.
How to test
src/pages/MyMove/SelectShipmentType.jsx
right under the consthasOconusDutyLocation
A: is_oconus = true for origin duty location -> can select UBs
B. is_oconus = true for new duty location -> can select UBs
C. is_oconus = true for both origin and new duty locations -> can select UBs
D. is_oconus = false for BOTH duty locations -> can NOT select UBs
Frontend
Screenshots
No UBs selectable tooltip:
![image](https://private-user-images.githubusercontent.com/147537467/376797775-5aa05a0d-02d4-49d5-bb9b-41c3228d048b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MTgzNjcsIm5iZiI6MTczOTQxODA2NywicGF0aCI6Ii8xNDc1Mzc0NjcvMzc2Nzk3Nzc1LTVhYTA1YTBkLTAyZDQtNDlkNS1iYjliLTQxYzMyMjhkMDQ4Yi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxM1QwMzQxMDdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yMDc0NTQwNzcyM2VjZGVkMTI2N2Q5YTNkNjUzZTYyMzRhZDBkMmQxZjE1NGExNjE5ZDFjZDViZTI5YmY1NDIyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.FlkyX6h153isrnn44Xk6-ODiAx-nH8gkl0qUR2OrboM)
Tooltip when UBs are selectable/508 compliance:
![image](https://private-user-images.githubusercontent.com/147537467/376800876-6917e0f8-b92a-4162-9eae-d4a04c8cc380.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MTgzNjcsIm5iZiI6MTczOTQxODA2NywicGF0aCI6Ii8xNDc1Mzc0NjcvMzc2ODAwODc2LTY5MTdlMGY4LWI5MmEtNDE2Mi05ZWFlLWQ0YTA0YzhjYzM4MC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxM1QwMzQxMDdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mOTQwMmRjMjJlNTI3OGMwMWMyMWRmNzhkODZiYTY3YTllYzcxOGFlZTg0NDQ3ZTY2NWZmZDRkNDk2MjNlYzEzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.F39DaVsdMB9OtUf9dEnfuBOCMvBLc1mHnvommvI6-V8)
UB selectable 508 compliance:
![image](https://private-user-images.githubusercontent.com/147537467/376803744-aa4d9e9d-6bda-4080-a6e0-cf8d3fac3f2a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MTgzNjcsIm5iZiI6MTczOTQxODA2NywicGF0aCI6Ii8xNDc1Mzc0NjcvMzc2ODAzNzQ0LWFhNGQ5ZTlkLTZiZGEtNDA4MC1hNmUwLWNmOGQzZmFjM2YyYS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxM1QwMzQxMDdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03YmMwZDJjYThkZThkM2FmOTlmZTEwMzJjNmI5NTk0ZTk3OGMxMWMxMThlNzVjYWZmM2Y1NWIwMDRhYjhjNzMxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.ZI7MU6zqSQivNuznDRID_6ai2LNWmOuyFVGzQm08mNk)