Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B-21364 FF: UB shipments selectable for OCONUS duty locations #13917

Merged
merged 15 commits into from
Oct 17, 2024

Conversation

traskowskycaci
Copy link
Contributor

@traskowskycaci traskowskycaci commented Oct 15, 2024

Agility ticket

Summary

The work here is to conditionally allow UB (Unaccompanied Baggage) shipments as selectable if either the origin or new duty locations are considered OCONUS. If at least one of the duty locations on the orders have an isOconus value of true, then we allow the customer to select UBs as a shipment type.

The selecting of UBs on the "How should this shipment move?" page IS feature flagged off.

There are upstreams of this story to pay attention to before merging into main:
B-21427 & B-21430: #13849
B-21365: #13878
B-21362 & B-21363: #13837

B-21481: This is NOT an upstream that impacts functionality/merge order, but does impact being able to test this in loadtest. This PR (21364) CAN go ahead of B-21481 as far as merge order.

How to test

  1. Access the milmove app as a customer
  2. Create a new service member
  3. Create a new move, stopping at the orders screen
  4. Pick two different values for the origin and new duty locations
  5. Add your orders, but stop at the page where you pick your orders that says "How should this shipment move?"
  6. Verify that you do not see UB as a selectable shipment
    image
  7. Click on the tooltip next to the HHG or PPM shipments
  8. Verify that you do not see anything mentioning UB in that tooltip
    image
  9. For easier testing, you can add this to src/pages/MyMove/SelectShipmentType.jsx right under the const hasOconusDutyLocation
    const originDutyLocation = orders[0].origin_duty_location.address;
    console.log('originDutyLocation');
    console.log(originDutyLocation);
    const newDutyLocation = orders[0].new_duty_location.address;
    console.log('newDutyLocation');
    console.log(newDutyLocation);
    console.log('hasOconusDutyLocation');
    console.log(hasOconusDutyLocation);

  1. Pull up your console and grab the two address ids:
    image
  2. Pull them up in dbeaver:
    image
  3. Verify that they both have is_oconus set to false.
  4. Modify one of the values to be true
  5. Refresh your page, and verify that you STILL don't see UBs as selectable. This is because the UB FF isn't on yet, but you just tested the FF functionality, congrats!
  6. Kill your server, pull up .envrc and set FEATURE_FLAG_UNACCOMPANIED_BAGGAGE to true. Run direnv allow and then rerun your server.
  7. If you still have one or both of the address is_oconus fields set to true, you should be able to just refresh your page and see that UB is now selectable!
    image
  8. Verify that the tooltip also now has an explanation of UBs under the HHG and PPM blurbs:
    image
  9. Run through the following test cases:
    A: is_oconus = true for origin duty location -> can select UBs
    B. is_oconus = true for new duty location -> can select UBs
    C. is_oconus = true for both origin and new duty locations -> can select UBs
    D. is_oconus = false for BOTH duty locations -> can NOT select UBs
  10. Go back and make sure you tested case D because it's important
  11. Continue through the flow of creating the UB shipment, picking UB on the "How should this shipment move" page
  12. Verify that you can see UB at the top of the next page:
    image
  13. Fill out all the info and make sure you see the UB shipment card:
    image
  14. Verify that the UB shipment type is accurate and appears in the DB:
    image
  15. Make sure you can review the UB on this page:
    image
  16. Review and submit and finish the move:
    image

Frontend

Screenshots

No UBs selectable tooltip:
image

Tooltip when UBs are selectable/508 compliance:
image

UB selectable 508 compliance:
image

@traskowskycaci traskowskycaci self-assigned this Oct 15, 2024
@traskowskycaci traskowskycaci added Mountain Movers Movin' Mountains 1 Sprint at a time INTEGRATION Slated for Integration Testing labels Oct 15, 2024
@traskowskycaci traskowskycaci marked this pull request as ready for review October 15, 2024 21:29
@traskowskycaci traskowskycaci changed the title B 21364 int B-21364 FF: UB Shipments Selectable if OCONUS duty location Oct 15, 2024
@traskowskycaci traskowskycaci changed the title B-21364 FF: UB Shipments Selectable if OCONUS duty location B-21364 FF: UB shipments selectable for OCONUS duty locations Oct 15, 2024
Copy link
Contributor

@cameroncaci cameroncaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked great, code looks good, and the FF on the modal help tooltip is 🤌

Meets AC

Copy link
Contributor

@TevinAdams TevinAdams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me. Code reviewed. ACs look satisfied.

Copy link
Contributor

@danieljordan-caci danieljordan-caci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a pesky little test file for MoveInfoModal and just a small bit on what you currently have. Looks good though on both desktop and mobile!

Screenshot 2024-10-16 at 8 58 49 AM
Screenshot 2024-10-16 at 8 58 55 AM

src/pages/MyMove/SelectShipmentType.jsx Show resolved Hide resolved
@traskowskycaci traskowskycaci merged commit baa564f into integrationTesting Oct 17, 2024
30 checks passed
@traskowskycaci traskowskycaci deleted the B-21364-INT branch October 17, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Mountain Movers Movin' Mountains 1 Sprint at a time
Development

Successfully merging this pull request may close these issues.

4 participants