-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B-21365 Customer UB Shipment Card - INT #13878
Conversation
MAIN B-19226 Onboarding required fields
|
{!isUB && ( | ||
<Alert headingLevel="h4" type="info" noIcon> | ||
Remember: You can move {formatWeight(orders.authorizedWeight)} total. You’ll be billed for any | ||
excess weight you move. | ||
</Alert> | ||
)} | ||
{isUB && ( | ||
<Alert headingLevel="h4" type="info" noIcon> | ||
Remember: You can move up to your UB allowance for this move. You’ll be billed for any excess | ||
weight you move. | ||
</Alert> | ||
)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just doing a quick static review before pulling, but this can be shortened:
<Alert headingLevel="h4" type="info" noIcon>
Remember: You can move {isUB ? 'up to your UB allowance for this move' : formatWeight(orders.authorizedWeight) + ' total'}.
You’ll be billed for any excess weight you move.
</Alert>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TevinAdams Looks like you tried to delete as the office user - this is only for the customer. I just tested again and delete works as the customer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agility ticket
Summary
Note: As there is still no way to create a UB shipment strictly with the UI, the work done in this BL item is not feature flagged off. All work here is only seen after a UB shipment is created via the createMTOShipment endpoint with either swagger or postman.
This work is to refine the customer UI for the UB shipment card, shipment container, and shipment list. A bonus of us reusing the HHG components is that some of the functionality just falls in - such as editing/deleting shipments.
How to test
You should see the shipments appear now:
![image](https://private-user-images.githubusercontent.com/147537467/375538856-a4ab9bc4-afc9-4455-8e44-6a2ad76b2df7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwNTA1ODEsIm5iZiI6MTczOTA1MDI4MSwicGF0aCI6Ii8xNDc1Mzc0NjcvMzc1NTM4ODU2LWE0YWI5YmM0LWFmYzktNDQ1NS04ZTQ0LTZhMmFkNzZiMmRmNy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOFQyMTMxMjFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mN2I0N2Q5ZjAwOGRjNjA1MmUzYjI4NjlmZWNmODJkNjUzM2FmNjRhYjg1ZmVlZmJhNjE4ZmM0ZDU1YWE5NDdmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.602gbVOnIthP6XAjds0ppI-apxw8CyBtiXMzeY_zLAU)
![image](https://private-user-images.githubusercontent.com/147537467/375539173-90b52d1b-6a60-461e-9ec6-55aca2385417.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwNTA1ODEsIm5iZiI6MTczOTA1MDI4MSwicGF0aCI6Ii8xNDc1Mzc0NjcvMzc1NTM5MTczLTkwYjUyZDFiLTZhNjAtNDYxZS05ZWM2LTU1YWNhMjM4NTQxNy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOFQyMTMxMjFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01OWJlNGU5OTZiM2EwN2FhZDQ2YTMxMGUxMjdjMjJmY2ZiYWZiZDQ2MDZmYjYwZjkwMmVmMmI3ZWMwYzk0MjgzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.9MD6jrkKmnA-GA7htSPwUlUgDf2cqDs7b4fGS-qHJN0)
3. Click the edit button for all UBs you created, and fill out all the information as you would with an HHG:
Click the Review and submit button:
![image](https://private-user-images.githubusercontent.com/147537467/375538960-28c650b1-5f2a-4c16-af72-095105def90c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwNTA1ODEsIm5iZiI6MTczOTA1MDI4MSwicGF0aCI6Ii8xNDc1Mzc0NjcvMzc1NTM4OTYwLTI4YzY1MGIxLTVmMmEtNGMxNi1hZjcyLTA5NTEwNWRlZjkwYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOFQyMTMxMjFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jZmRkNDZlZTMyNDExNWMzNGUzNTAyM2ZjODQxYjA3YjNlMGViZWQ1M2IzMzExYTE4MjI4ZDlmYmFjZjMyZWNiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.usbSWUaJY-hvODjc4rh_OYijzzKBL97DsKspXNzUM9I)
You should see the normal HHG shipment card:
![image](https://private-user-images.githubusercontent.com/147537467/375539411-513e6657-2b58-4daa-94d5-a2d2e3e35f2d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwNTA1ODEsIm5iZiI6MTczOTA1MDI4MSwicGF0aCI6Ii8xNDc1Mzc0NjcvMzc1NTM5NDExLTUxM2U2NjU3LTJiNTgtNGRhYS05NGQ1LWEyZDJlM2UzNWYyZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOFQyMTMxMjFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jNmRiZDM3NjUzZTgwMjBhNmFiNmJhMjdlNDYzNDlkNzIzZjYzYjc0OGZiOTQ2ZGJjMTRhYWMzMTE5OWIzMTA1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.lNXS5rYCAcckYjV03Ug_r1CBlx2oIdCa44dJWa0a1ks)
You should also see the new UB shipment card, which reuses the HHG shipment card component so it will look very similar in structure, but be labeled as UB:
![image](https://private-user-images.githubusercontent.com/147537467/375539605-c1d20933-65d8-4029-bac0-d941b35d39cd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwNTA1ODEsIm5iZiI6MTczOTA1MDI4MSwicGF0aCI6Ii8xNDc1Mzc0NjcvMzc1NTM5NjA1LWMxZDIwOTMzLTY1ZDgtNDAyOS1iYWMwLWQ5NDFiMzVkMzljZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOFQyMTMxMjFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00OWFlZDY2OGY5MzU2NmM5OGQ3YmFlYjAwZjU5OWRjNjBiOWM2NTg4NWUwOTU3ZDU0MzhkZTY3OWNkM2E5MTZmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.UVSJUKDDmxVg24S_O-r1Ok6UtYfINGYnU3jyocporKU)
Extra credit: since we are reusing so much of the HHG functionality for this, test out that deleting the shipment also works. Technically not in scope for this PR but it's nice that it works.
Frontend