Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B-21365 Customer UB Shipment Card - INT #13878

Merged
merged 23 commits into from
Oct 11, 2024
Merged

Conversation

traskowskycaci
Copy link
Contributor

@traskowskycaci traskowskycaci commented Oct 10, 2024

Agility ticket

Summary

Note: As there is still no way to create a UB shipment strictly with the UI, the work done in this BL item is not feature flagged off. All work here is only seen after a UB shipment is created via the createMTOShipment endpoint with either swagger or postman.

This work is to refine the customer UI for the UB shipment card, shipment container, and shipment list. A bonus of us reusing the HHG components is that some of the functionality just falls in - such as editing/deleting shipments.

How to test

  1. Access the milmove app as a customer, create a move and an HHG shipment. Do not complete the move.
  2. Using the createMTOShipment endpoint, create a UB or two.
{
  "moveTaskOrderID": "yourMoveIDHere",
  "shipmentType": "UNACCOMPANIED_BAGGAGE",
  "requestedPickupDate": "2024-10-04",
  "pickupAddress": {
      "streetAddress1": "123 Main St",
      "city": "Nicholasville",
      "state": "KY",
      "postalCode": "40356",
      "country": "US",
      "county": "JESSAMINE"
   }
}

You should see the shipments appear now:
image
3. Click the edit button for all UBs you created, and fill out all the information as you would with an HHG:
image

  1. Click the Review and submit button:
    image

  2. You should see the normal HHG shipment card:
    image

  3. You should also see the new UB shipment card, which reuses the HHG shipment card component so it will look very similar in structure, but be labeled as UB:
    image

  4. Extra credit: since we are reusing so much of the HHG functionality for this, test out that deleting the shipment also works. Technically not in scope for this PR but it's nice that it works.

Frontend

@robot-mymove
Copy link

robot-mymove commented Oct 10, 2024

Warnings
⚠️

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?

View the frontend file org ADR for more information

Generated by 🚫 dangerJS against 9233289

@traskowskycaci traskowskycaci changed the title B 21365 int B-21365 Customer UB Shipment Card - INT Oct 10, 2024
@traskowskycaci traskowskycaci self-assigned this Oct 10, 2024
@traskowskycaci traskowskycaci added Mountain Movers Movin' Mountains 1 Sprint at a time INTEGRATION Slated for Integration Testing labels Oct 10, 2024
@traskowskycaci traskowskycaci marked this pull request as ready for review October 10, 2024 22:14
Comment on lines 318 to 329
{!isUB && (
<Alert headingLevel="h4" type="info" noIcon>
Remember: You can move {formatWeight(orders.authorizedWeight)} total. You’ll be billed for any
excess weight you move.
</Alert>
)}
{isUB && (
<Alert headingLevel="h4" type="info" noIcon>
Remember: You can move up to your UB allowance for this move. You’ll be billed for any excess
weight you move.
</Alert>
)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just doing a quick static review before pulling, but this can be shortened:

<Alert headingLevel="h4" type="info" noIcon>
  Remember: You can move {isUB ? 'up to your UB allowance for this move' : formatWeight(orders.authorizedWeight) + ' total'}. 
  You’ll be billed for any excess weight you move.
</Alert>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Copy link
Contributor

@TevinAdams TevinAdams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed code and test case passed, except for deleting the UB Shipment. Clicked the delete button but nothing happened. ACs have been met.

Screenshot 2024-10-11 at 8 35 45 AM Screenshot 2024-10-11 at 8 39 12 AM Screenshot 2024-10-11 at 8 40 46 AM

@traskowskycaci
Copy link
Contributor Author

Reviewed code and test case passed, except for deleting the UB Shipment. Clicked the delete button but nothing happened. ACs have been met.

@TevinAdams Looks like you tried to delete as the office user - this is only for the customer. I just tested again and delete works as the customer

Copy link
Contributor

@danieljordan-caci danieljordan-caci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked purdy good!

Screenshot 2024-10-11 at 10 26 18 AM
Screenshot 2024-10-11 at 10 26 42 AM

@traskowskycaci traskowskycaci merged commit a62ed74 into integrationTesting Oct 11, 2024
30 checks passed
@traskowskycaci traskowskycaci deleted the B-21365-INT branch October 11, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Mountain Movers Movin' Mountains 1 Sprint at a time
Development

Successfully merging this pull request may close these issues.

6 participants