Ignore Explain Plan Queries (PAYINP-2326) #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configure the default table access statistics to ignore explain plan queries, via the default query parser interceptor. Explain plan queries don't really access the tables, so there shouldn't really be a need to include these queries in the statistics. Additionally, JSQLParser fails to parse them, which causes warnings to be emitted in services using the library.
onukristo
approved these changes
Feb 14, 2024
|
/wise-bot emergency-merge sboms system is broken and getting fixed, meanwhile this is only way to merge. |
wise-github-bot-app
bot
added
the
change:emergency
|
🟢 Emergency merge requested by onukristo. This event has been added to the security log. The merge could take few seconds... Remember that, once it is merged, a maintainer should review the code and approve it retrospectively by commenting
|
|
/wise-bot approve |
|
Approved by ajmalab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Configure the default table access statistics to ignore explain plan queries, via the default query parser interceptor.
Explain plan queries don't really access the tables, so there shouldn't really be a need to include these queries in the statistics. Additionally, JSQLParser fails to parse them, which causes warnings to be emitted in services using the library.
Example warnings about parsing failures:
https://app.rollbar.com/a/Wise/fix/item/payin-service/42591
https://app.rollbar.com/a/Wise/fix/item/payin-service/42590
Checklist