Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore Explain Plan Queries (PAYINP-2326) #43

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Ignore Explain Plan Queries (PAYINP-2326) #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres
to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [2.16.0] - 2024-02-14

### Changed

* Ignore explain plan queries, which are generated by tw-reliable-jdbc, as they do not really access the tables and JSQLParser fails to parse them


## [2.15.0] - 2024-01-25

* Upgrading libraries, mainly the JSqlParser, to support more queries out of the box.
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
version=2.15.0
version=2.16.0
2 changes: 1 addition & 1 deletion ...nsferwise/common/entrypoints/tableaccessstatistics/DefaultTasQueryParsingInterceptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

public class DefaultTasQueryParsingInterceptor implements TasQueryParsingInterceptor {

private static Pattern PG_SET_PATTERN = Pattern.compile("(?is)SET\\s+[a-z_]*\\s+TO\\s+.*");
private static final Pattern PG_SET_PATTERN = Pattern.compile("(?is)SET\\s+[a-z_]*\\s+TO\\s+.*|EXPLAIN\\s+.*");

@Override
public InterceptResult intercept(String sql) {
Expand Down
9 changes: 9 additions & 0 deletions ...st/java/com/transferwise/common/entrypoints/tableaccessstatistics/SqlParserUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,15 @@ void testJSqlParser() {
testCases.add(new TestCase("set idle_in_transaction_session_timeout to '600000'",
List.of()));

testCases.add(new TestCase("EXPLAIN FORMAT=JSON select * from fx.request where id = 1",
List.of()));
testCases.add(new TestCase("explain FORMAT=JSON select * from fx.request where id = 1",
List.of()));
testCases.add(new TestCase("EXPLAIN (FORMAT JSON) select * from fx.request where id = 1",
List.of()));
testCases.add(new TestCase("explain (FORMAT JSON) select * from fx.request where id = 1",
List.of()));

testCases.add(new TestCase("insert into fin_unique_tw_task_key(task_id,key_hash,key) values(?, ?, ?) on conflict (key_hash, key) do nothing",
List.of("fin_unique_tw_task_key")));

Expand Down
Loading