core: Pass newFile with all the info to onBeforeFileAdded #1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Added and onBeforeUpload callbacks Addresses #1545, but I’m not sure this is the right move. Is it better to check restrictions before or after the callbacks?
arturi
changed the title
This was referenced Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
newFilewith all the info toonBeforeFileAdded— this wayfile.typewill be set and other properties likemetaandisRemotewill be available toonBeforeFileAddedcallback._checkRestrictionsand_checkMinNumberOfFilesbeforeonBeforeFileAddedandonBeforeUploadcallbacks — not sure about this one, @goto-bus-stop. Should restrictions be run before or after callbacks? 🤔 The issue was raised in Restrictions should be enforced before calling onBeforeUpload #1545.