core: Restrictions improvements #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atch works, emit restriction-failed for minNumberOfFiles, too We must throw in upload onError, otherwise .catch won’t catch
probably a leftover from before StautsBar became a standalone plugin
arturi
commented
Jul 15, 2019
This was referenced Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
onBeforeFileAddedcallback. This way you’ll get a meaningful type in the callback, instead of an empty string or an incorrect one.restriction-failedforminNumberOfFiles, too (so inuppy.upload()). Not sure about the signature in this case, it is(file, err)for when a file restriction fails, and I made it(null, err)for when it’sminNumberOfFiles.return Promise.reject()had to be changed tothrow—Promise.rejectwasn’t caught in.catch(). Without this it throws an error in console.restrictions.allowedFileTypesis not an array.This PR supersedes #1594, since we’ve decided it has breaking changes.
Closes #1594