-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: add more bundlers for automated testing #4100
Conversation
- name: Bundle | ||
run: npx vite build | ||
|
||
esbuild: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vite uses esbuild under the hood and we use Vite always in development so perhaps those aren't strictly required. But it doesn't hurt either, as long as it doesn't stall CI too long.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I thought that originally, but actually we have custom config for our dev setup, the idea is to test the defaults – or as close as the defaults as possible so users can see what's the minimal config change they need to do to make Uppy works for their setup.
Also, if one fail but not the other, that'd give us more info on what's broken.
| Package | Version | Package | Version | | ---------------------- | ------- | ---------------------- | ------- | | @uppy/angular | 0.5.1 | @uppy/companion-client | 3.1.1 | | @uppy/aws-s3-multipart | 3.1.1 | @uppy/utils | 5.1.1 | | @uppy/companion | 4.1.1 | uppy | 3.3.1 | - @uppy/aws-s3-multipart: handle slow connections better (Antoine du Hamel / #4213) - @uppy/companion-client: treat `*` the same as missing header (Antoine du Hamel / #4221) - @uppy/utils: fix types (Antoine du Hamel / #4212) - @uppy/companion: send expire info for non-multipart uploads (Antoine du Hamel / #4214) - docs: fix `allowedMetaFields` documentation (Antoine du Hamel / #4216) - meta: add more bundlers for automated testing (Antoine du Hamel / #4100) - @uppy/aws-s3-multipart: Fix typo in url check (Christian Franke / #4211) - meta: use current version of packages when testing bundlers (Antoine du Hamel / #4208) - meta: do not use the set-output command in workflows (Antoine du Hamel / #4175)
* main: (110 commits) @uppy/aws-s3-multipart: handle slow connections better (#4213) @uppy/companion-client: treat `*` the same as missing header (#4221) @uppy/utils: fix types (#4212) @uppy/companion: send expire info for non-multipart uploads (#4214) docs: fix `allowedMetaFields` documentation (#4216) meta: add more bundlers for automated testing (#4100) @uppy/aws-s3-multipart: Fix typo in url check (#4211) meta: use current version of packages when testing bundlers (#4208) meta: do not use the set-output command in workflows (#4175) Release: uppy@3.3.0 (#4207) Companion: change default S3 expiry from 300 to 800 seconds (#4206) Dashboard: Single file mode (#4188) Fix UZ locale (#4178) @uppy/utils: update typings for `RateLimitedQueue` (#4204) @uppy/aws-s3-multipart: empty the queue when pausing (#4203) image-editor: add checkered background (#4194) @uppy/aws-s3-multipart: refactor rate limiting approach (#4187) @uppy/companion: send expiry time along side S3 signed requests (#4202) @uppy/companion-client: add support for `AbortSignal` (#4201) @uppy/companion-client: prevent preflight race condition (#4182) ...
| Package | Version | Package | Version | | ---------------------- | ------- | ---------------------- | ------- | | @uppy/angular | 0.5.1 | @uppy/companion-client | 3.1.1 | | @uppy/aws-s3-multipart | 3.1.1 | @uppy/utils | 5.1.1 | | @uppy/companion | 4.1.1 | uppy | 3.3.1 | - @uppy/aws-s3-multipart: handle slow connections better (Antoine du Hamel / transloadit#4213) - @uppy/companion-client: treat `*` the same as missing header (Antoine du Hamel / transloadit#4221) - @uppy/utils: fix types (Antoine du Hamel / transloadit#4212) - @uppy/companion: send expire info for non-multipart uploads (Antoine du Hamel / transloadit#4214) - docs: fix `allowedMetaFields` documentation (Antoine du Hamel / transloadit#4216) - meta: add more bundlers for automated testing (Antoine du Hamel / transloadit#4100) - @uppy/aws-s3-multipart: Fix typo in url check (Christian Franke / transloadit#4211) - meta: use current version of packages when testing bundlers (Antoine du Hamel / transloadit#4208) - meta: do not use the set-output command in workflows (Antoine du Hamel / transloadit#4175)
No description provided.