Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@uppy/companion-client: treat * the same as missing header #4221

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 16, 2022

Setting Access-Control-Allow-Headers: * should be interpreted as when that header is missing, for backward compat.

Setting `Access-Control-Allow-Headers: *` should be interpreted as
when that header is missing, for backward compat.
@aduh95 aduh95 linked an issue Nov 16, 2022 that may be closed by this pull request
2 tasks
@aduh95 aduh95 added safe to test Add this label on trustworthy PRs to spawn the e2e test suite and removed pending end-to-end tests labels Nov 16, 2022
@github-actions github-actions bot removed the safe to test Add this label on trustworthy PRs to spawn the e2e test suite label Nov 16, 2022
@aduh95 aduh95 merged commit 92a0b20 into transloadit:main Nov 16, 2022
@aduh95 aduh95 deleted the fix-header-star branch November 16, 2022 13:56
@github-actions github-actions bot mentioned this pull request Nov 16, 2022
github-actions bot added a commit that referenced this pull request Nov 16, 2022
| Package                | Version | Package                | Version |
| ---------------------- | ------- | ---------------------- | ------- |
| @uppy/angular          |   0.5.1 | @uppy/companion-client |   3.1.1 |
| @uppy/aws-s3-multipart |   3.1.1 | @uppy/utils            |   5.1.1 |
| @uppy/companion        |   4.1.1 | uppy                   |   3.3.1 |

- @uppy/aws-s3-multipart: handle slow connections better (Antoine du Hamel / #4213)
- @uppy/companion-client: treat `*` the same as missing header (Antoine du Hamel / #4221)
- @uppy/utils: fix types (Antoine du Hamel / #4212)
- @uppy/companion: send expire info for non-multipart uploads (Antoine du Hamel / #4214)
- docs: fix `allowedMetaFields` documentation (Antoine du Hamel / #4216)
- meta: add more bundlers for automated testing (Antoine du Hamel / #4100)
- @uppy/aws-s3-multipart: Fix typo in url check (Christian Franke / #4211)
- meta: use current version of packages when testing bundlers (Antoine du Hamel / #4208)
- meta: do not use the set-output command in workflows (Antoine du Hamel / #4175)
Murderlon added a commit that referenced this pull request Dec 1, 2022
* main: (110 commits)
  @uppy/aws-s3-multipart: handle slow connections better (#4213)
  @uppy/companion-client: treat `*` the same as missing header (#4221)
  @uppy/utils: fix types (#4212)
  @uppy/companion: send expire info for non-multipart uploads (#4214)
  docs: fix `allowedMetaFields` documentation (#4216)
  meta: add more bundlers for automated testing (#4100)
  @uppy/aws-s3-multipart: Fix typo in url check (#4211)
  meta: use current version of packages when testing bundlers (#4208)
  meta: do not use the set-output command in workflows (#4175)
  Release: uppy@3.3.0 (#4207)
  Companion: change default S3 expiry from 300 to 800 seconds (#4206)
  Dashboard: Single file mode (#4188)
  Fix UZ locale (#4178)
  @uppy/utils: update typings for `RateLimitedQueue` (#4204)
  @uppy/aws-s3-multipart: empty the queue when pausing (#4203)
  image-editor: add checkered background (#4194)
  @uppy/aws-s3-multipart: refactor rate limiting approach (#4187)
  @uppy/companion: send expiry time along side S3 signed requests (#4202)
  @uppy/companion-client: add support for `AbortSignal` (#4201)
  @uppy/companion-client: prevent preflight race condition (#4182)
  ...
HeavenFox pushed a commit to docsend/uppy that referenced this pull request Jun 27, 2023
| Package                | Version | Package                | Version |
| ---------------------- | ------- | ---------------------- | ------- |
| @uppy/angular          |   0.5.1 | @uppy/companion-client |   3.1.1 |
| @uppy/aws-s3-multipart |   3.1.1 | @uppy/utils            |   5.1.1 |
| @uppy/companion        |   4.1.1 | uppy                   |   3.3.1 |

- @uppy/aws-s3-multipart: handle slow connections better (Antoine du Hamel / transloadit#4213)
- @uppy/companion-client: treat `*` the same as missing header (Antoine du Hamel / transloadit#4221)
- @uppy/utils: fix types (Antoine du Hamel / transloadit#4212)
- @uppy/companion: send expire info for non-multipart uploads (Antoine du Hamel / transloadit#4214)
- docs: fix `allowedMetaFields` documentation (Antoine du Hamel / transloadit#4216)
- meta: add more bundlers for automated testing (Antoine du Hamel / transloadit#4100)
- @uppy/aws-s3-multipart: Fix typo in url check (Christian Franke / transloadit#4211)
- meta: use current version of packages when testing bundlers (Antoine du Hamel / transloadit#4208)
- meta: do not use the set-output command in workflows (Antoine du Hamel / transloadit#4175)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access-Control-Allow-Headers wildcard not handled in companion client
2 participants