@uppy/aws-s3: update type and deprecate timeout option
#4298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
commented
Apr 25, 2023
Murderlon
approved these changes
Apr 26, 2023
Merged
github-actions bot
added a commit
that referenced
this pull request
May 2, 2023
| Package | Version | Package | Version | | ---------------------- | ------- | ---------------------- | ------- | | @uppy/aws-s3 | 3.1.1 | @uppy/status-bar | 3.1.2 | | @uppy/aws-s3-multipart | 3.3.0 | @uppy/transloadit | 3.1.4 | | @uppy/locales | 3.2.1 | uppy | 3.9.0 | - @uppy/aws-s3-multipart: allowedMetaFields: null means “include all” (Artur Paikin / #4437) - @uppy/aws-s3-multipart: add `shouldUseMultipart ` option (Antoine du Hamel / #4205) - @uppy/transloadit: Reset `tus` key in the file on error, so retried files are re-uploaded (Artur Paikin / #4421) - meta: commit build file that was modified (Antoine du Hamel) - meta: examples: add CORS settings for DigitalOcean Spaces (Antoine du Hamel / #4428) - @uppy/aws-s3: deprecate `timeout` option (Antoine du Hamel / #4298) - @uppy/aws-s3-multipart: make retries more robust (Antoine du Hamel / #4424) - meta: fix badges on README (Antoine du Hamel / #4419)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a timeout on the client side doesn't make much sense IMO, a more reasonable approach seems to be to use the
Expiresvalue reported by the backend that tells Uppy when the signature expires (at which point the upload is guaranteed to fail, so it makes sense to cancel the upload).The plan is to remove the option entirely on the next major, at the same time as we combine both
@uppy/aws-s3and@uppy/aws-s3-multipart, which doesn't have this option.If you are using this option and would not like it to be removed, please comment on this thread.