@uppy/aws-s3-multipart: make retries more robust #4424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the user clicks retries, we need to have cleared up all the cache regarding the file to retry, otherwise we are likely to target an already expired ID.
aduh95
commented
Apr 20, 2023
aduh95
added
the
safe to test
github-actions
bot
removed
the
safe to test
arturi
approved these changes
Apr 21, 2023
aduh95
added
the
safe to test
github-actions
bot
removed
pending end-to-end tests
safe to test
|
@Murderlon do you want to review the test to make sure we did everything by the book? We want to test that for each request type, a failure is reported to the user and the retry functionality can end up in a successful state when it finally goes through. |
Murderlon
approved these changes
Apr 25, 2023
Merged
github-actions bot
added a commit
that referenced
this pull request
May 2, 2023
| Package | Version | Package | Version | | ---------------------- | ------- | ---------------------- | ------- | | @uppy/aws-s3 | 3.1.1 | @uppy/status-bar | 3.1.2 | | @uppy/aws-s3-multipart | 3.3.0 | @uppy/transloadit | 3.1.4 | | @uppy/locales | 3.2.1 | uppy | 3.9.0 | - @uppy/aws-s3-multipart: allowedMetaFields: null means “include all” (Artur Paikin / #4437) - @uppy/aws-s3-multipart: add `shouldUseMultipart ` option (Antoine du Hamel / #4205) - @uppy/transloadit: Reset `tus` key in the file on error, so retried files are re-uploaded (Artur Paikin / #4421) - meta: commit build file that was modified (Antoine du Hamel) - meta: examples: add CORS settings for DigitalOcean Spaces (Antoine du Hamel / #4428) - @uppy/aws-s3: deprecate `timeout` option (Antoine du Hamel / #4298) - @uppy/aws-s3-multipart: make retries more robust (Antoine du Hamel / #4424) - meta: fix badges on README (Antoine du Hamel / #4419)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user clicks retries, we need to have cleared up all the cache regarding the file to retry, otherwise we are likely to target an already expired ID.
Fixes: #4366