simplify findDOMElements

[mifi]

why do we need generics here?

[github-actions]

Diff output files

diff --git a/packages/@uppy/utils/lib/findDOMElement.js b/packages/@uppy/utils/lib/findDOMElement.js
index 848cf8d..014ff83 100644
--- a/packages/@uppy/utils/lib/findDOMElement.js
+++ b/packages/@uppy/utils/lib/findDOMElement.js
@@ -1,5 +1,5 @@
 import isDOMElement from "./isDOMElement.js";
-export default function findDOMElement(element, context) {
+function findDOMElement(element, context) {
   if (context === void 0) {
     context = document;
   }
@@ -11,3 +11,4 @@ export default function findDOMElement(element, context) {
   }
   return null;
 }
+export default findDOMElement;

[aduh95]

This makes the types less precise, what's the upside of this?

[mifi]

not sure why this precision is useful. it makes the function harder to understand and adds the need to @ts-expect-error three times. do you have an example of when this generic would be useful? i cannot find any in its current usages

[aduh95]

@mifi it's about having TS generate the correct types, which could help us catch bugs before they affect users. See https://www.typescriptlang.org/play?#code/CYUwxgNghgTiAEAzArgOzAFwJYHtXywGcARAeQFkBRCEAWxFQwAoQb7GAueNAa1RwDuqAJRdWdBhgKF41CYwBQCkAA8ADjhhSU6bHiRZUwMlTaTSMLAHNDUCAB4AKgD4mC+PHHsMXRwBp3eDA8DFUfeGIcMGRveABeeGAomMkA0XhHTxVQoxk5WIB+DIVfLJzgGQA5HFB4AB94QgxLVCt4IvzJevhUZAgIEp6+iHgAb0CsRHgmDABPNRAcKa8uuLX4AHImlqsN4THAjwB6I-gAAQxCAFpVBcwbmBhNdoLXw-g4DGQYfGDGMIAdABHZAgGCzADK4kwmhYZkYwkCAF8lB5JtMiCZOow4fIMMJ9uMPMdThdrrdwBgHk8YC83sSPiAvj9PPCMMjUfATudLjd1JTqc9XvTGcz8L1+goUcp1JptGhMLh8IhDMYKNiMBDkFYrCAmiBgG4PCtONxUHxBKgAh4-qFslxItFYgkkk7Ugp0hruhKRkSCFMZvNFss2fF1ltmoZdoT3p9vr8QoCQWDIdCMLCTfiORMA5j1Wzcd4CQcGXGWZnsx4y+LhlKlAoVUYsWyLNZbBAmK6UowAQAjGqzYQAyBQQiEAAyRAwAKgwENACJkGo1LN58IANwN1XNvFanV60KGrvePsDocjseTpozudMRfL1cbrmnACC+CgqH4syjnkez0QmhgD+yAyOm3CEAgo4QVoSqEEojZqqYeKtjYqB2EwPrCAAhMO0CXlON4LkuK5rpuCE7t4e66vqhqYThF4TgRs5EQ+pHPvA1QZBCv40n4iR6moWChPAvYgD+OC9gAbrgIEQLM8BQPAtBTlAPAgEoQA for an example where the more precise types could be useful.

[mifi]

ok, now I understand, thanks. still learning typescript & generics!

[mifi]

I did some more reading and learned more about function overloads in TS. I think using overloads we can make the types more correct because we don't have to disable typechecking on the return values with ts-expect-error - see updated playground: https://www.typescriptlang.org/play?#code/CYUwxgNghgTiAEAzArgOzAFwJYHtXywGcARAeQFkBRCEAWxFQwAoQb7GAueNAa1RwDuqAJRdWdBhgKF41CYwBQSlOmx4kWVMDJU2k0jCwBzTVAgAeACoA+Jgvjxx7DF0sAae-DB4MIAB4YAPxcxDhgyM4eovCWjgEMwDJyzvCBMQqucb5aMgByOKDwAD7whBiGqEapsnqMxfCoyBAQGQ1NLQoqmLj4iJraFMn6hiaoZnYOTpJcQ3Ul+YUlZRVVJY3NHg7ejP4u8KHhKQC88MBhEZJRM7VSa+3wAN6eWIjwTBgAngAOIDivU3UjkD4AByZaaIwg4SPTwOOAYZAwfDbXwBAB0AEdkCAYB8AMriTA4GAsG7CTwAXyUDhebyIOlmzABGGE0KeDjhIARSMcN0p1Pg8MR+HWLSpCn8X2JUi6al6-QZNzxyCMRhAZRAwAmvPke14-CEmy8Pl2IXOx1O5suCmijPqophNNe72+v3+N3gQJOYPKEKhjo5Qp5KN2mOxuIJNCJJOZ5Ic4qddJIgxupN1rIDnO5+GZ-M8QZF7QU4s6CpTuoMxlMECYZ0OkjRACMCh9hGjIFBCIQADJEDBoqDALUAImQXy+H2HwgA3KWtIrdcrVerfFq6xdGE2W22O13e2UB0OmKPx5OZ-AAPQX+AAQXwUFQ-A+EMcMBgxKQxLAL+QMgwOG4QgEE7ICYDlQhlDLXQKxGasmFFYQAEJ22gPc+0PEcxwnKdZz6edy2cJc1Q1LUEOQ3ce3QwdMNPHDL2vfIYjxV93xgNxTnVL4sF8eBGxAF8cEbAA3XBfwgD54CgeBaD7KAeBAJQgA

[aduh95]

Interesting that TS would need overload for that, but as long as it works 👍

Two small nits to make the types even more precise:

[mifi]

i found it here: https://stackoverflow.com/a/52818072/6519037
I think using generics with conditional types is just a different way of expressing multiple overloads instead of having to write them all out