@uppy/xhr-upload: fix getResponseData regression

[Murderlon]

Fixes #4963

[github-actions]

Diff output files

diff --git a/packages/@uppy/xhr-upload/lib/index.js b/packages/@uppy/xhr-upload/lib/index.js
index c9d4e85..4c45cea 100644
--- a/packages/@uppy/xhr-upload/lib/index.js
+++ b/packages/@uppy/xhr-upload/lib/index.js
@@ -53,7 +53,11 @@ const defaultOptions = {
   withCredentials: false,
   responseType: "",
   getResponseData(responseText) {
-    return JSON.parse(responseText);
+    let parsedResponse = {};
+    try {
+      parsedResponse = JSON.parse(responseText);
+    } catch {}
+    return parsedResponse;
   },
   getResponseError(_, response) {
     let error = new Error("Upload error");

[aduh95]

I don't think an empty object is a correct response here, undefined would be more appropriate, no?

Suggested change

	let parsedResponse = {}
	try {
	parsedResponse = JSON.parse(responseText)
	} catch {
	// ignore
	}
	// We don't have access to the B (Body) generic here
	// so we have to cast it to any. The user facing types
	// remain correct, this is only to please the merging of default options.
	return parsedResponse as any
	try {
	return JSON.parse(responseText)
	} catch {
	// ignore
	}

or

Suggested change

	let parsedResponse = {}
	try {
	parsedResponse = JSON.parse(responseText)
	} catch {
	// ignore
	}
	// We don't have access to the B (Body) generic here
	// so we have to cast it to any. The user facing types
	// remain correct, this is only to please the merging of default options.
	return parsedResponse as any
	if (responseText) return JSON.parse(responseText)

[Murderlon]

It's a regression because it used to return {}, until I accidentally removed it in #4892. So {} is what is has to be for now.