Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toggleAddFilesPanel() - make args consistent #5365

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

lakesare
Copy link
Collaborator

Previously it worked because props.toggleAddFilesPanel(event) is also truthy 😞
This was setting state.showAddFilesPanel to event.

@lakesare lakesare requested review from aduh95 and Murderlon and removed request for aduh95 July 24, 2024 01:58
Copy link
Contributor

Diff output files
diff --git a/packages/@uppy/dashboard/lib/components/FileItem/FileInfo/index.js b/packages/@uppy/dashboard/lib/components/FileItem/FileInfo/index.js
index 07b4bf7..3c1cbd5 100644
--- a/packages/@uppy/dashboard/lib/components/FileItem/FileInfo/index.js
+++ b/packages/@uppy/dashboard/lib/components/FileItem/FileInfo/index.js
@@ -59,7 +59,7 @@ const ReSelectButton = props =>
     h("button", {
       className: "uppy-u-reset uppy-c-btn uppy-Dashboard-Item-reSelect",
       type: "button",
-      onClick: props.toggleAddFilesPanel,
+      onClick: () => props.toggleAddFilesPanel(true),
     }, props.i18n("reSelect")),
   );
 const ErrorButton = _ref => {

@aduh95 aduh95 merged commit c2ed04e into main Jul 29, 2024
17 checks passed
@aduh95 aduh95 deleted the lakesare/consistent-toggleAddFilesPanel branch July 29, 2024 08:38
@github-actions github-actions bot mentioned this pull request Jul 30, 2024
github-actions bot added a commit that referenced this pull request Jul 30, 2024
| Package              | Version | Package              | Version |
| -------------------- | ------- | -------------------- | ------- |
| @uppy/audio          |   2.0.1 | @uppy/status-bar     |   4.0.1 |
| @uppy/aws-s3         |   4.0.2 | @uppy/store-default  |   4.1.0 |
| @uppy/compressor     |   2.0.1 | @uppy/transloadit    |   4.0.1 |
| @uppy/core           |   4.1.0 | @uppy/utils          |   6.0.1 |
| @uppy/dashboard      |   4.0.2 | @uppy/webcam         |   4.0.1 |
| @uppy/remote-sources |   2.1.0 | uppy                 |   4.1.0 |

- @uppy/remote-sources: fix options type (Merlijn Vos / #5364)
- @uppy/transloadit: do not mark `opts` as mandatory (Antoine du Hamel / #5375)
- @uppy/compressor: mark `quality` as optional (Antoine du Hamel / #5374)
- @uppy/aws-s3: improve error when `endpoint` is not provided (Antoine du Hamel / #5361)
- @uppy/core,@uppy/store-default: export `Store` type (Merlijn Vos / #5373)
- @uppy/dashboard: make `toggleAddFilesPanel` args consistent (Evgenia Karunus / #5365)
- @uppy/dashboard: Dashboard - convert some files to typescript (Evgenia Karunus / #5359)
- @uppy/audio,@uppy/webcam: Don't use `<h1>` in Uppy markup (Evgenia Karunus / #5355)
- @uppy/status-bar: GoldenRetriever + `hideUploadButton=true` (Evgenia Karunus / #5350)
- meta: Bump docker/build-push-action from 6.3.0 to 6.4.1 (dependabot[bot] / #5360)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants