Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toggleAddFilesPanel() - make args consistent #5365

Merged
merged 1 commit into from
Jul 29, 2024
Merged

toggleAddFilesPanel() - make args consistent #5365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/@uppy/dashboard/src/components/FileItem/FileInfo/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@

const ReSelectButton = (props: {
file: UppyFile<any, any>
toggleAddFilesPanel: () => void
toggleAddFilesPanel: (show: boolean) => void
i18n: I18n
}) =>
props.file.isGhost && (
Expand All @@ -85,7 +85,7 @@
<button
className="uppy-u-reset uppy-c-btn uppy-Dashboard-Item-reSelect"
type="button"
onClick={props.toggleAddFilesPanel}
onClick={() => props.toggleAddFilesPanel(true)}
>
{props.i18n('reSelect')}
</button>
Expand Down Expand Up @@ -121,7 +121,7 @@
containerWidth: number
containerHeight: number
i18n: I18n
toggleAddFilesPanel: () => void
toggleAddFilesPanel: (show: boolean) => void
toggleFileCard: (show: boolean, fileId: string) => void
metaFields: DashboardState<any, any>['metaFields']
isSingleFile: boolean
Expand Down Expand Up @@ -150,7 +150,7 @@
containerHeight,
containerWidth,
})}
<ErrorButton file={file} onClick={() => alert(file.error)} />

Check warning on line 153 in packages/@uppy/dashboard/src/components/FileItem/FileInfo/index.tsx

View workflow job for this annotation

GitHub Actions / Lint JavaScript/TypeScript 

Unexpected alert
</div>
<div className="uppy-Dashboard-Item-status">
{renderAuthor({ file })}
Expand Down
2 changes: 1 addition & 1 deletion packages/@uppy/dashboard/src/components/FileItem/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ type Props<M extends Meta, B extends Body> = {
id: string
containerWidth: number
containerHeight: number
toggleAddFilesPanel: () => void
toggleAddFilesPanel: (show: boolean) => void
isSingleFile: boolean
hideRetryButton: boolean
hideCancelButton: boolean
Expand Down
2 changes: 1 addition & 1 deletion packages/@uppy/dashboard/src/components/FileList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ type FileListProps<M extends Meta, B extends Body> = {
itemsPerRow: number
openFileEditor: (file: UppyFile<M, B>) => void
canEditFile: (file: UppyFile<M, B>) => boolean
toggleAddFilesPanel: () => void
toggleAddFilesPanel: (show: boolean) => void
containerWidth: number
containerHeight: number
}
Expand Down