Conversation
User complained that local one has `-d` but s3 doesn't.
shcheklein
reviewed
Jan 6, 2020
shcheklein
approved these changes
Jan 7, 2020
Contributor
|
Thinking about it, I'm not sure why we wanted to change this example over a single user's feedback. I think having significantly different examples is a good thing. Maybe we should revert? |
jorgeorpinel
added a commit
that referenced
this pull request
Jan 12, 2020
Contributor
Contributor
Author
|
@jorgeorpinel Not worth reverting in my opinion. This PR just made it consistent within one doc. I think that complaint was a reasonable one. |
Contributor
|
Understood, but I've already rewritten the examples of that doc anyway, please see #915 (review). Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User complained that local one has
-dbut s3 doesn't.Disregard the recommendations below if you use Edit on GitHub button to improve the docs in place.
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue(if applicable) in the description of the PR. This enables GitHub to link the PR to the corresponding bug and close it automatically when PR is merged.Thank you for the contribution - we'll try to review and merge it as soon as possible. 🙏