doc: regular updates (mid Jan) #915
Conversation
and other improvements near the changed text per #914 (review)
jorgeorpinel
force-pushed
the
jorgeorpinel
branch
from
2ad1255 to
c88d436
Compare
shcheklein
left a comment
shcheklein
left a comment
There was a problem hiding this comment.
good to go, just a few comments. thanks 🎉
| import Tutorials from '../Tutorials' | ||
| import Tooltip from '../../Tooltip' | ||
| import Collapsible from 'react-collapsible' | ||
| // syntax highlighter |
There was a problem hiding this comment.
same here - let's not do this right now. Let's postpone cosmetic JS changes please and wait for @iAdramelk to wrap up the two major branches.
There was a problem hiding this comment.
You mean not to remove those unnecessary comments? I thought we agreed to remove them. Should I bring them back? Up to you, but I think a simple removal like this is very unlikely to produce merge conflicts.
There was a problem hiding this comment.
yes, I mean not do a lot of cosmetic changes to JS at this moment. We can do it later. It might create conflicts for @iAdramelk for no good reason.
There was a problem hiding this comment.
OK... Reverted https://github.com/iterative/dvc.org/compare/4950d25..7ea2edb in c64d590. This is the 2nd time these changes get reverted so I'll just forget about this until/if someone else brings it up 😋
shcheklein
left a comment
shcheklein
left a comment
There was a problem hiding this comment.
check a few comments - otherwise looks good to me.
2 participants
Misc. stuff +