Extend Privacy Policy with used Google scopes#954
Conversation
|
@Maxris @jorgeorpinel any idea why it does not run CircleCI for this branch from the top of your head? |
|
|
||
| ## Scopes | ||
|
|
||
| userinfo.email scope (view your email address), userinfo.profile scope (see your |
There was a problem hiding this comment.
let's use userinfo.email (inline code) blocks for scope names to make a bit more readable
There was a problem hiding this comment.
@shcheklein have updated markup and have added mention about drive.appdata scope as well.
Not sure why CicrcleCI won't start (how it might be related to my GitHub account).
There was a problem hiding this comment.
@Maxris don't worry about this for now. Have asked their support to check what the issue could be.
| your personal info, including any personal info you've made publicly available), | ||
| and `openid` scope (authenticate using OpenID Connect) are required to be used | ||
| by Google Auth. DVC authorizes users via | ||
| [Google's server](https://accounts.google.com/o/oauth2/auth) and doesn't access |
There was a problem hiding this comment.
Hi! This link doesn't work like this. Should we just display it instead like `https://accounts.google.com/o/oauth2/auth` ?
There was a problem hiding this comment.
Hey @jorgeorpinel , the idea here was to mention explicitly that server belongs to Google and link was added just as a prove. Also link might change with time.
There was a problem hiding this comment.
Also not sure why it doesn't work? I can click at "Google's server" text and the URL is opened in new tab ( error in new tab is displayed, but it is fine )
There was a problem hiding this comment.
I think @jorgeorpinel refers to the fact that it returns 404 and looks like broken bc of that. Also trigger our CI scripts that detect broken/dead links. I've added it to the exclusion list for now. Still, not clear if it makes sense to keep it this way, even though I understand the intention.
There was a problem hiding this comment.
Yep, we need it in the link exclusion list anyway, but it's best to display the link in the markdown like a `quote` instead of a clickable link, I think.
And yes, I meant it's not a link to any useful website. It doesn't work like that = it's not meant to be navigated, just the base URL to begin a OAuth authentication (but needs a special token in the URL query)
There was a problem hiding this comment.
@jorgeorpinel got it, thanks, should I propose the changes?
There was a problem hiding this comment.
@jorgeorpinel let's fix it as part of the regular updates flow.
|
Sorry to keep kicking a dead horse but I have another follow up question to this PR guys: Will the current guide in https://dvc.org/doc/user-guide/setup-google-drive-remote be completely rewritten soon? Since we're using a default DVC Application on GCP it seems to me the guide will be much simpler, but maybe this isn't completely done yet (Google APIs verification process). |
|
@jorgeorpinel it'll be augmented most likely, not rewritten. We still recommend using your own app/project. |
3 participants
No description provided.