Skip to content

Conversation

@jorgeorpinel
Copy link
Contributor

No description provided.

@shcheklein shcheklein temporarily deployed to dvc-landing-2010-02-10-3ezhg7q February 10, 2020 22:01 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2010-02-10-3ezhg7q February 10, 2020 22:26 Inactive
@jorgeorpinel

This comment has been minimized.

@shcheklein

This comment has been minimized.

@jorgeorpinel
Copy link
Contributor Author

I agree. But it's also not a user guide. It wold be nice to be able to not have it in the sidebar I guess, just linked from some place... Maybe work on #731 ?

BTW, should re remove the current link from the footer then? And put it in the remote add and remote modify cmd refs.

@shcheklein
Copy link
Contributor

shcheklein commented Feb 10, 2020

@jorgeorpinel don't see it as a big deal right now, let's get back to this discussion when we start the User Guide restructuring.

footer link was requested by the Google verification team.

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2010-02-10-3ezhg7q February 11, 2020 00:03 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2010-02-10-3ezhg7q February 11, 2020 01:25 Inactive
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Feb 11, 2020

don't see it as a big deal right now, let's get back to this discussion when we start the User Guide restructuring

OK, noted in #144 (comment)

footer link was requested by the Google verification team

OK, can I rename it "Google APIs Privacy Policy" just for correctness? Typically a link like this on the footer is a general privacy policy for data collection of DVC itself, not specific to the integration in this case. But we don't really collect any personal data, so its a bit misleading.

jorgeorpinel added a commit that referenced this pull request Feb 11, 2020
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2010-02-10-3ezhg7q February 11, 2020 01:35 Inactive
@treeverse treeverse deleted a comment from shcheklein Feb 11, 2020
@shcheklein
Copy link
Contributor

OK, can I rename it "Google APIs Privacy Policy" just for correctness?

Let's not mess with this right now. We can think how to generalize, improve this, etc later, way later.

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2010-02-10-3ezhg7q February 11, 2020 01:41 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2010-02-10-3ezhg7q February 11, 2020 01:50 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2010-02-10-3ezhg7q February 11, 2020 01:53 Inactive
Copy link
Contributor

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge it, not wait for more unrelated changes 🙏

@jorgeorpinel jorgeorpinel changed the title Regular updates (Feb 10+) more GAPI privacy policy updates Feb 11, 2020
@jorgeorpinel jorgeorpinel marked this pull request as ready for review February 11, 2020 02:07
@jorgeorpinel
Copy link
Contributor Author

OK, I renamed the PR, merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants