Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating branch from the UI, select the default branch as source #652

Closed
nopcoder opened this issue Sep 25, 2020 · 7 comments · Fixed by #805
Closed

When creating branch from the UI, select the default branch as source #652

nopcoder opened this issue Sep 25, 2020 · 7 comments · Fixed by #805
Labels
area/UI Improvements or additions to UI good first issue Good for newcomers hacktoberfest Issues that can get you awesome swag!

Comments

@nopcoder
Copy link
Contributor

nopcoder commented Sep 25, 2020

On create a new branch, the source branch default value should select the repository default branch

@nopcoder nopcoder added good first issue Good for newcomers hacktoberfest Issues that can get you awesome swag! labels Sep 25, 2020
@johnnyaug johnnyaug changed the title WebUI create branch default source branch When creating branch from the UI,In the UI, select the default branch as source Sep 27, 2020
@johnnyaug johnnyaug changed the title When creating branch from the UI,In the UI, select the default branch as source When creating branch from the UI, select the default branch as source Sep 27, 2020
@johnnyaug johnnyaug added the area/UI Improvements or additions to UI label Sep 27, 2020
@haardikdharma10
Copy link

Hi @nopcoder, can you help me on getting started with this?

@ramesht007
Copy link

Hey @nopcoder , can I work on this.

@nopcoder
Copy link
Contributor Author

nopcoder commented Sep 30, 2020

yes, did you managed to run a local dev environment and see the issue?
any of you have an experience in React?

@iamRishabh07
Copy link

Hi, @nopcoder I would like to work on this issue

@nopcoder
Copy link
Contributor Author

nopcoder commented Oct 1, 2020

anybody who likes to work on this issue, thanks, I just need to know that you understand what is the problem and you have experience in React.

@adithyaakrishna
Copy link

Hi @nopcoder I've good experience in building React Apps, Some of my projects are in my profile My Github Profile
I would like to work on this issue 🚀

@arc9693
Copy link

arc9693 commented Oct 2, 2020

@nopcoder Hey. I ran on my local and observed the issue. I think this is where we need work:

const [selectedBranch, setSelectedBranch] = useState(null);

We need to pass the value of the default branch name as an initial value to useState hook instead of null or some other way by which we update "selected" to the default branch, as soon as branches load in the following section:
const RefDropdown = ({ repo, selected, selectRef, onCancel, prefix = '', emptyText = '', withCommits = true, withWorkspace = true }) => {

I would like to work on this. I have experience in React.
Can i take this up?

johnnyaug pushed a commit that referenced this issue Oct 14, 2020
* set source branch to default_branch

* Replaced masterBranch with defaultBranch to maintain terminology

* linter fix for BranchesPage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI Improvements or additions to UI good first issue Good for newcomers hacktoberfest Issues that can get you awesome swag!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants