Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#652 select the default branch as source #805

Merged
merged 3 commits into from
Oct 14, 2020
Merged

#652 select the default branch as source #805

merged 3 commits into from
Oct 14, 2020

Conversation

fumblehool
Copy link
Contributor

Fixes #652

@CLAassistant
Copy link

CLAassistant commented Oct 12, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

johnnyaug
johnnyaug reviewed Oct 13, 2020
View reviewed changes
Copy link
Contributor

@johnnyaug johnnyaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fumblehool, welcome and thank you for you effort!
Looks very good. I would just change the "masterBranch" variable name to "defaultBranch" which is our current terminology. Once you change that I will approve and merge.

Thanks again

@fumblehool
Copy link
Contributor Author

@johnnyaug Thanks for the review, I've updated the variable name as per the terminology.

@johnnyaug johnnyaug merged commit 05cd0b0 into treeverse:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyaug johnnyaug johnnyaug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When creating branch from the UI, select the default branch as source
3 participants
@fumblehool @CLAassistant @johnnyaug