Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete branch button is missing #956

Closed
itaiad200 opened this issue Nov 24, 2020 · 5 comments · Fixed by #991
Closed

Delete branch button is missing #956

itaiad200 opened this issue Nov 24, 2020 · 5 comments · Fixed by #991
Assignees
Labels
area/UI Improvements or additions to UI good first issue Good for newcomers

Comments

@itaiad200
Copy link
Contributor

No description provided.

@itaiad200 itaiad200 added area/UI Improvements or additions to UI good first issue Good for newcomers labels Nov 24, 2020
@shamikakumar
Copy link
Contributor

I'd like to work on this issue, could I have more information..

@itaiad200
Copy link
Contributor Author

Sure - assigned. Under the branches tab, each non-default branch should have the delete button.
After the user clicked, an approval pop-up appears which warns about the branch deletion.
When the actions is approved, a deletion request is sent.
image

@shamikakumar
Copy link
Contributor

shamikakumar commented Dec 1, 2020

@itaiad200 I finished the UI part, where I added a delete button for the non-default branches and an approval pop up for branch deletion. However I didn't do the delete call request as I believe it requires code changes in Go that I'm not familiar with..need some help with that

@itaiad200
Copy link
Contributor Author

@shamikakumar Delete branch is already supported by the api, so no Go code changes are needed. However The call is missing from the UI, an appropriate place for it would be alongside other branch operation calls, here.

@shamikakumar
Copy link
Contributor

@itaiad200 I've implemented it, do review and let me know

itaiad200 pushed a commit that referenced this issue Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI Improvements or additions to UI good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants