Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/delete branch #956 #991

Merged
merged 11 commits into from
Dec 9, 2020

Conversation

shamikakumar
Copy link
Contributor

In Branches page, added delete functionality for non-default branches. Fixes #956

@codecov-io
Copy link

Codecov Report

Merging #991 (cce67e3) into master (9623170) will decrease coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #991      +/-   ##
==========================================
- Coverage   44.56%   44.22%   -0.34%     
==========================================
  Files         142      140       -2     
  Lines       11547    11570      +23     
==========================================
- Hits         5146     5117      -29     
- Misses       5758     5804      +46     
- Partials      643      649       +6     
Impacted Files Coverage Δ
config/logger.go 64.28% <0.00%> (-10.72%) ⬇️
catalog/mvcc/validate.go 88.23% <0.00%> (-6.21%) ⬇️
stats/collector.go 61.36% <0.00%> (-0.71%) ⬇️
api/handler.go 70.83% <0.00%> (ø)
gateway/operations/base.go 0.00% <0.00%> (ø)
catalog/mvcc/cataloger_merge.go 73.33% <0.00%> (ø)
catalog/mvcc/cataloger_delete_multipart_upload.go
catalog/mvcc/cataloger_get_multipart_upload.go
catalog/mvcc/cataloger_create_multipart_upload.go
gateway/multiparts/tracker.go 0.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9623170...cce67e3. Read the comment docs.

@itaiad200
Copy link
Contributor

LGTM
Great job @shamikakumar !

@itaiad200 itaiad200 merged commit 93b4222 into treeverse:master Dec 9, 2020
@shamikakumar shamikakumar deleted the fix/delete-branch-#956 branch December 9, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete branch button is missing
3 participants