Local adapter clean user input before file access #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielshaqed
approved these changes
Dec 13, 2020
Codecov Report
@@ Coverage Diff @@
## master #1037 +/- ##
==========================================
+ Coverage 46.86% 46.99% +0.12%
==========================================
Files 179 182 +3
Lines 14069 14301 +232
==========================================
+ Hits 6594 6721 +127
- Misses 6607 6686 +79
- Partials 868 894 +26
Continue to review full report at Codecov.
|
arielshaqed
approved these changes
Dec 29, 2020
block/local/adapter.go
Outdated
Comment on lines
355
to
358
| func isValidUploadID(uploadID string) bool { | ||
| _, err := strconv.ParseUint(uploadID, 16, 64) | ||
| return err != nil | ||
| } |
There was a problem hiding this comment.
Consider returning error, and then using this error message to wrap ErrInvalidUploadIDFormat. That might give the caller more information about what went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is