allow lakectl local to be "git data" #7618
Conversation
ozkatz
added
improvement
include-changelog
E2E Test Results - DynamoDB Local - Local Block Adapter |
|
♻️ PR Preview 2442446 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
cmd/lakectl/cmd/local_install.go
Outdated
| Args: cobra.ExactArgs(1), | ||
| Run: func(cmd *cobra.Command, args []string) { | ||
| installDir := args[0] | ||
| if strings.HasPrefix(installDir, "~/") { |
There was a problem hiding this comment.
We're already using homedir.Expand in our code - you can use it here too
| if !info.IsDir() { | ||
| DieFmt("%s: not a directory.\n", installDir) | ||
| } | ||
|
|
There was a problem hiding this comment.
Do we also want to verify it's in the path?
There was a problem hiding this comment.
That's possibly error prone: git is sometimes a script that sets up environment variables before calling the executable, so we can't guarantee the current $PATH is the one used when executing.
|
|
||
| var localInstallGitPluginCmd = &cobra.Command{ | ||
| Use: "install-git-plugin <directory>", | ||
| Short: "set up `git data` (directory must exist and be in $PATH)", |
There was a problem hiding this comment.
Can we add a long description here? I think in this case it's important to describe exactly how to use it
| ctx := context.Background() | ||
|
|
||
| var cmd *cobra.Command | ||
| baseName := getBasename() |
There was a problem hiding this comment.
nit: might want to extract that to a "setupLocalCommand" function
|
@N-o-Z added tests, not sure why Esti is completely failing now :( would appreciate some help |
I wouldn't say completely :) just the new test that was added. Also needed to generate the cli docs. |
There was a problem hiding this comment.
Very nice!!
Can you please update https://docs.lakefs.io/howto/local-checkouts.html so that it includes the option to use git data?
ozkatz
force-pushed
the
improvement/lakectl-local-git-data
branch
from
013b427 to
2fdb65f
Compare
ozkatz
force-pushed
the
improvement/lakectl-local-git-data
branch
from
2fdb65f to
6365141
Compare
Allow symlinking lakectl -->
git-datawhich would triggerlakectl localasgit data.This enables calling:
$ git data clone ... $ git data status $ git data commit -m "..."And so on.
Set up:
Will put a symlink called
git-datainto that path. Calling lakectl by that name will automatically execute thelakectl localsubcommand. By default, callinggit <subcommand>where<subcommand>isn't an existing git command will executegit-<subcommand>.