Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "allow lakectl local to be 'git data' (#7618)" #7654

Merged
merged 1 commit into from
Apr 14, 2024
Merged

Revert "allow lakectl local to be 'git data' (#7618)" #7654

merged 1 commit into from
Apr 14, 2024

Conversation

ozkatz
Copy link
Collaborator

@ozkatz ozkatz commented Apr 10, 2024

please don't hate me, reviewers!

@ozkatz ozkatz added minor-change Used for PRs that don't require issue attached lakectl-local labels Apr 10, 2024
@ozkatz ozkatz requested review from N-o-Z, itaiad200 and talSofer April 10, 2024 12:09
@ozkatz ozkatz self-assigned this Apr 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 10, 2024 •
edited
Loading

♻️ PR Preview 0f8daa0 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@github-actions GitHub Actions
Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

@itaiad200
Copy link
Contributor

I think we need an issue with context.. Also - adding the plugin was changelog material, so should be the removal

N-o-Z
N-o-Z approved these changes Apr 13, 2024
View reviewed changes
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ozkatz Planning on releasing a new version tomorrow. Let's merge this before?

@ozkatz
Copy link
Collaborator Author

ozkatz commented Apr 14, 2024

Closes #7667

@ozkatz ozkatz linked an issue Apr 14, 2024 that may be closed by this pull request
Overlap of naming for lakectl local and git data might be confusing #7667
Closed
@ozkatz ozkatz added include-changelog PR description should be included in next release changelog and removed minor-change Used for PRs that don't require issue attached labels Apr 14, 2024
@ozkatz ozkatz merged commit 090edc8 into master Apr 14, 2024
40 of 44 checks passed
@ozkatz ozkatz deleted the feature/no-git-data branch April 14, 2024 09:25
emulatorchen pushed a commit to emulatorchen/lakeFS that referenced this pull request May 27, 2024
@ozkatz
Revert "allow lakectl local to be "git data" (treeverse#7618)" (treev…
a04e17c 
…erse#7654)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talSofer talSofer talSofer approved these changes

@N-o-Z N-o-Z N-o-Z approved these changes

@itaiad200 itaiad200 Awaiting requested review from itaiad200

Assignees

@ozkatz ozkatz

Labels
include-changelog PR description should be included in next release changelog lakectl-local
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overlap of naming for lakectl local and git data might be confusing
4 participants
@ozkatz @itaiad200 @N-o-Z @talSofer